[Payment Request] Updates AutofillEditItem to reuse in Payment Request

[Payment Request] Updates AutofillEditItem to reuse in Payment Request

1. Adds a card type icon image to the AutofillEditItem for use as the
credit card number input field in Payment Request.
2. Updates the existing Autofill form to display that image.

screenshots: http://imgur.com/a/Q2yNb

BUG=602666
TBR=mathp@

Review-Url: https://codereview.chromium.org/2731293002
Cr-Commit-Position: refs/heads/master@{#454881}
Committed: https://chromium.googlesource.com/chromium/src/+/c3cd10e07d20e7498c94a3fbe3735f0bb68c3296

[Moe, 2017-03-06 15:12:44]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org, mathp@chromium.org

[Moe, 2017-03-06 15:12:45]

Hi Louis, Please take a look.
TBR=mathp@

[Moe, 2017-03-06 15:12:58]

Description was changed from

==========
[Payment Request] Updates AutofillEditItem to reuse in Payment Request

1. Adds a card type icon image to the AutofillEditItem for use as the
credit card number input field in Payment Request.
2. Updates the existing Autofill form to display that image.

BUG=602666
==========

to

==========
[Payment Request] Updates AutofillEditItem to reuse in Payment Request

1. Adds a card type icon image to the AutofillEditItem for use as the
credit card number input field in Payment Request.
2. Updates the existing Autofill form to display that image.

screenshots: http://imgur.com/a/Q2yNb

BUG=602666
==========

[lpromero, 2017-03-06 16:18:16]

lgtm

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
File
ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
(right):

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm:214:
// Update the cells.
*cell

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
File
ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h
(right):

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h:14:
- (NSIndexPath*)indexPathForCurrentTextField;
Why not making it a public API instead?

[Moe, 2017-03-06 16:29:44]

Description was changed from

==========
[Payment Request] Updates AutofillEditItem to reuse in Payment Request

1. Adds a card type icon image to the AutofillEditItem for use as the
credit card number input field in Payment Request.
2. Updates the existing Autofill form to display that image.

screenshots: http://imgur.com/a/Q2yNb

BUG=602666
==========

to

==========
[Payment Request] Updates AutofillEditItem to reuse in Payment Request

1. Adds a card type icon image to the AutofillEditItem for use as the
credit card number input field in Payment Request.
2. Updates the existing Autofill form to display that image.

screenshots: http://imgur.com/a/Q2yNb

BUG=602666

TBR=mathp@
==========

[Moe, 2017-03-06 16:29:52]

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
File
ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
(right):

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm:214:
// Update the cells.
On 2017/03/06 16:18:16, lpromero wrote:
> *cell

Done.

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
File
ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h
(right):

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h:14:
- (NSIndexPath*)indexPathForCurrentTextField;
On 2017/03/06 16:18:16, lpromero wrote:
> Why not making it a public API instead?

This method seems more like a utility method rather than to be in the public
API. Is this the standard way of inheriting protected methods?

[lpromero, 2017-03-06 16:36:00]

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
File
ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h
(right):

https://codereview.chromium.org/2731293002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h:14:
- (NSIndexPath*)indexPathForCurrentTextField;
On 2017/03/06 16:29:52, moe wrote:
> On 2017/03/06 16:18:16, lpromero wrote:
> > Why not making it a public API instead?
> 
> This method seems more like a utility method rather than to be in the public
> API. Is this the standard way of inheriting protected methods?  

We sometimes make a "Subclassing" category instead of "Protected".
it's just that there was not much harm in making it public.

I am fine as is.

[lpromero, 2017-03-06 16:36:07]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-03-06 16:36:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2731293002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-03-06 16:36:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 17:40:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488818167562950,
"parent_rev": "c26b5914b28e0a145481fec6d942f0dbba97e227", "commit_rev":
"c3cd10e07d20e7498c94a3fbe3735f0bb68c3296"}

[commit-bot: I haz the power, 2017-03-06 17:41:09]

Description was changed from

==========
[Payment Request] Updates AutofillEditItem to reuse in Payment Request

1. Adds a card type icon image to the AutofillEditItem for use as the
credit card number input field in Payment Request.
2. Updates the existing Autofill form to display that image.

screenshots: http://imgur.com/a/Q2yNb

BUG=602666

TBR=mathp@
==========

to

==========
[Payment Request] Updates AutofillEditItem to reuse in Payment Request

1. Adds a card type icon image to the AutofillEditItem for use as the
credit card number input field in Payment Request.
2. Updates the existing Autofill form to display that image.

screenshots: http://imgur.com/a/Q2yNb

BUG=602666

TBR=mathp@

Review-Url: https://codereview.chromium.org/2731293002
Cr-Commit-Position: refs/heads/master@{#454881}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3cd10e07d20e7498c94a3fbe373...
==========

[commit-bot: I haz the power, 2017-03-06 17:41:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3cd10e07d20e7498c94a3fbe373...

[Mathieu, 2017-03-06 20:14:06]

Thanks Moe, one comment

https://codereview.chromium.org/2731293002/diff/20001/ios/chrome/browser/ui/s...
File
ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
(right):

https://codereview.chromium.org/2731293002/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm:203:
- (void)textFieldDidEndEditing:(UITextField*)textField {
On other platforms I'm pretty sure we show the icon as soon as it's available
(i.e. this would be called at every keystroke). This way, if you enter "4" we
can already tell it's a VISA which is nice. 

Unless I'm wrong this will only be called when the user is done with the field. 

Could
https://developer.apple.com/reference/uikit/uitextfielddelegate/1619599-textf...
work instead?