ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h - Issue 2731293002: [Payment Request] Updates AutofillEditItem to reuse in Payment Request

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h

Issue 2731293002: [Payment Request] Updates AutofillEditItem to reuse in Payment Request (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm ('K') | « ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/cells/autofill_edit_item.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_SETTINGS_AUTOFILL_EDIT_COLLECTION_VIEW_CONTROLLER_ PROTECTED_H_

	6 #define IOS_CHROME_BROWSER_UI_SETTINGS_AUTOFILL_EDIT_COLLECTION_VIEW_CONTROLLER_ PROTECTED_H_

	7

	8 #import "ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller .h"

	9

	10 // The collection view for an Autofill edit entry menu.

	11 @interface AutofillEditCollectionViewController (Protected)

	12

	13 // Returns the indexPath for the currently focused text field when in edit mode.

	14 - (NSIndexPath*)indexPathForCurrentTextField;
	lpromero 2017/03/06 16:18:16 Why not making it a public API instead? Why not making it a public API instead? Moe 2017/03/06 16:29:52 This method seems more like a utility method rathe Show quoted text On 2017/03/06 16:18:16, lpromero wrote: > Why not making it a public API instead? This method seems more like a utility method rather than to be in the public API. Is this the standard way of inheriting protected methods? lpromero 2017/03/06 16:36:00 We sometimes make a "Subclassing" category instead Show quoted text On 2017/03/06 16:29:52, moe wrote: > On 2017/03/06 16:18:16, lpromero wrote: > > Why not making it a public API instead? > > This method seems more like a utility method rather than to be in the public > API. Is this the standard way of inheriting protected methods? We sometimes make a "Subclassing" category instead of "Protected". it's just that there was not much harm in making it public. I am fine as is.
	15

	16 @end

	17

	18 #endif // IOS_CHROME_BROWSER_UI_SETTINGS_AUTOFILL_EDIT_COLLECTION_VIEW_CONTROLL ER_PROTECTED_H_

OLD	NEW