Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2731183002: V8ScriptValueDeserializer: Fix off-by-one issue in length comparison. (Closed)

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V8ScriptValueDeserializer: Fix off-by-one issue in length comparison. BUG=698141 Review-Url: https://codereview.chromium.org/2731183002 Cr-Commit-Position: refs/heads/master@{#454812} Committed: https://chromium.googlesource.com/chromium/src/+/5bc43cef665b4180f278a893ad56ee4b27756c76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
Totally trivial. This did originally say ">=", and I must have inadvertently dropped one character ...
3 years, 9 months ago (2017-03-05 15:37:15 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-06 01:49:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731183002/1
3 years, 9 months ago (2017-03-06 01:54:57 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 01:59:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bc43cef665b4180f278a893ad56...

Powered by Google App Engine
This is Rietveld 408576698