third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp - Issue 2731183002: V8ScriptValueDeserializer: Fix off-by-one issue in length comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

Issue 2731183002: V8ScriptValueDeserializer: Fix off-by-one issue in length comparison. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

index 726030fed014917838338ca488c087a69036f1fc..516ec902c1aa37efdce1418070c8f6eb78751b06 100644

--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

@@ -54,7 +54,7 @@ size_t readVersionEnvelope(SerializedScriptValue* serializedScriptValue,

unsigned shift = 0;

bool hasAnotherByte;

do {

- if (i > length)

+ if (i >= length)

return 0;

uint8_t byte = rawData[i];

if (LIKELY(shift < 32)) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »