Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2731153002: Fix two flaky media notification tests (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix two flaky media notification tests There are two media notification tests flaky because of the test pages are not set properly in BUILD.gn. This CL adds two test pages in `media/session` test data directory so that they are copied onto the device as they are executed. The `media/session` test data directory is already in BUILD.gn so no changes there needed. BUG=697453 Review-Url: https://codereview.chromium.org/2722233002 Cr-Commit-Position: refs/heads/master@{#453991} (cherry picked from commit 778f0744fecc3c50d4d23b0df97e3eaef9cbf817) Review-Url: https://codereview.chromium.org/2731153002 . Cr-Commit-Position: refs/branch-heads/2987@{#764} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java View 3 chunks +6 lines, -6 lines 0 comments Download
A content/test/data/media/session/title1.html View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/media/session/title2.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-04 13:27:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83.

Powered by Google App Engine
This is Rietveld 408576698