Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2722233002: Fix two flaky media notification tests (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
whywhat
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix two flaky media notification tests There are two media notification tests flaky because of the test pages are not set properly in BUILD.gn. This CL adds two test pages in `media/session` test data directory so that they are copied onto the device as they are executed. The `media/session` test data directory is already in BUILD.gn so no changes there needed. BUG=697453 Review-Url: https://codereview.chromium.org/2722233002 Cr-Commit-Position: refs/heads/master@{#453991} Committed: https://chromium.googlesource.com/chromium/src/+/778f0744fecc3c50d4d23b0df97e3eaef9cbf817

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java View 3 chunks +6 lines, -8 lines 0 comments Download
A content/test/data/media/session/title1.html View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/media/session/title2.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Zhiqiang Zhang (Slow)
PTAL I'm "pretty sure" this fix "would" work lol
3 years, 9 months ago (2017-03-01 18:31:37 UTC) #4
whywhat
lgtm
3 years, 9 months ago (2017-03-01 18:42:55 UTC) #7
whywhat
TBH, I expected if the problem is in BUILD.gn, the fix would be there too ...
3 years, 9 months ago (2017-03-01 18:43:30 UTC) #8
Zhiqiang Zhang (Slow)
On 2017/03/01 at 18:43:30, avayvod wrote: > TBH, I expected if the problem is in ...
3 years, 9 months ago (2017-03-01 19:04:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722233002/20001
3 years, 9 months ago (2017-03-01 19:06:02 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 19:13:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/778f0744fecc3c50d4d23b0df97e...

Powered by Google App Engine
This is Rietveld 408576698