Convert Ozone GL OSMesa implementation.

Convert Ozone GL OSMesa implementation.

Convert Ozone GL code for OSMesa to use the GLOzone interface. This
simplifies the initialization code in ui/gl/ and lets every Ozone
platform fully define the GL implementations that are available.

BUG=643368
Review-Url: https://codereview.chromium.org/2731733002
Cr-Commit-Position: refs/heads/master@{#454681}
Committed: https://chromium.googlesource.com/chromium/src/+/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3

[kylechar, 2017-03-03 18:56:25]

kylechar@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2017-03-03 19:09:45]

lgtm + inquiry.

https://codereview.chromium.org/2731733002/diff/20001/ui/ozone/common/gl_ozon...
File ui/ozone/common/gl_ozone_osmesa.h (right):

https://codereview.chromium.org/2731733002/diff/20001/ui/ozone/common/gl_ozon...
ui/ozone/common/gl_ozone_osmesa.h:18: ~GLOzoneOSMesa() override {}
it use to be that you would have to put this in the .cc file to avoid making
windows unhappy. If we ever wanted to use ozone on windows, should you consider
doing that?

[kylechar, 2017-03-03 19:13:56]

https://codereview.chromium.org/2731733002/diff/20001/ui/ozone/common/gl_ozon...
File ui/ozone/common/gl_ozone_osmesa.h (right):

https://codereview.chromium.org/2731733002/diff/20001/ui/ozone/common/gl_ozon...
ui/ozone/common/gl_ozone_osmesa.h:18: ~GLOzoneOSMesa() override {}
On 2017/03/03 19:09:45, rjkroege wrote:
> it use to be that you would have to put this in the .cc file to avoid making
> windows unhappy. If we ever wanted to use ozone on windows, should you
consider
> doing that?

Moved to .cc.

[kylechar, 2017-03-03 19:14:10]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 19:14:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 19:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 19:17:38]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rjkroege, 2017-03-03 19:19:04]

thanks.

lgtm

[kylechar, 2017-03-03 19:45:46]

Patchset #4 (id:60001) has been deleted

[kylechar, 2017-03-03 19:47:54]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 19:48:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 20:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 20:05:35]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kylechar, 2017-03-03 20:15:30]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 20:15:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 21:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 21:10:35]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-03-03 21:26:02]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-03-03 21:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org
Link to the patchset: https://codereview.chromium.org/2731733002/#ps100001
(title: "Fix rebase.")

[commit-bot: I haz the power, 2017-03-03 21:26:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 21:31:02]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488576362468500,
"parent_rev": "eb817e15a1be327f188132642196a488a22c8a09", "commit_rev":
"2cb74b7eae8939042b92edd1fc277b6ab61f2fc3"}

[commit-bot: I haz the power, 2017-03-03 21:32:02]

Description was changed from

==========
Convert Ozone GL OSMesa implementation.

Convert Ozone GL code for OSMesa to use the GLOzone interface. This
simplifies the initialization code in ui/gl/ and lets every Ozone
platform fully define the GL implementations that are available.

BUG=643368
==========

to

==========
Convert Ozone GL OSMesa implementation.

Convert Ozone GL code for OSMesa to use the GLOzone interface. This
simplifies the initialization code in ui/gl/ and lets every Ozone
platform fully define the GL implementations that are available.

BUG=643368

Review-Url: https://codereview.chromium.org/2731733002
Cr-Commit-Position: refs/heads/master@{#454681}
Committed:
https://chromium.googlesource.com/chromium/src/+/2cb74b7eae8939042b92edd1fc27...
==========

[commit-bot: I haz the power, 2017-03-03 21:32:03]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2cb74b7eae8939042b92edd1fc27...