Rename FrameViewBase fields and methods *Widget* to ...FrameViewBase...

Rename FrameViewBase fields and methods *Widget* to ...FrameViewBase...

BUG=697351
Review-Url: https://codereview.chromium.org/2730773003
Cr-Commit-Position: refs/heads/master@{#454801}
Committed: https://chromium.googlesource.com/chromium/src/+/9a8931b10c979daa46b663e4ab409142b36d7db1

[joelhockey, 2017-03-03 05:55:15]

joelhockey@chromium.org changed reviewers:
+ haraken@chromium.org, sashab@chromium.org, slangley@chromium.org

[joelhockey, 2017-03-03 05:55:20]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 05:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-03-03 05:58:56]

I just want to check that this is the best renaming.

I have done:

convertToContainigWidget => convertToContainingFrameViewBase

The 'FrameViewBase' is a little cumbersome.  Maybe just 'FrameView' kind of
looks nicer:

convertToContainingWidget => convertToContainingFrameView

But I guess it is not technically correct since we have classes for
FrameViewBase and FrameView and hence we need to be specific and correct.

I will continue with many more CLs to convert methods with 'Widget' to become
'FrameViewBase'.

[joelhockey, 2017-03-03 06:01:11]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-03 06:01:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 06:01:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 06:01:24]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[joelhockey, 2017-03-03 06:33:41]

Description was changed from

==========
Rename FrameViewBase::convert[To|From]ContainingWidget to
...ContainingFrameViewBase.

BUG=697351
==========

to

==========
Rename FrameViewBase fields and methods *Widget* to
...ContainingFrameViewBase...

BUG=697351
==========

[joelhockey, 2017-03-03 06:33:53]

Description was changed from

==========
Rename FrameViewBase fields and methods *Widget* to
...ContainingFrameViewBase...

BUG=697351
==========

to

==========
Rename FrameViewBase fields and methods *Widget* to ...FrameViewBase...

BUG=697351
==========

[haraken, 2017-03-03 18:59:39]

"convertFromContainingFrameViewBase" sounds a bit verbose but I cannot come up
with a better name... LGTM.

[joelhockey, 2017-03-05 22:19:49]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-05 22:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-05 23:44:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488752389031830, "parent_rev":
"b3d5d90fb4c6ae5ff29506ac80fdd71d92ca2f29", "commit_rev":
"9a8931b10c979daa46b663e4ab409142b36d7db1"}

[commit-bot: I haz the power, 2017-03-05 23:45:25]

Description was changed from

==========
Rename FrameViewBase fields and methods *Widget* to ...FrameViewBase...

BUG=697351
==========

to

==========
Rename FrameViewBase fields and methods *Widget* to ...FrameViewBase...

BUG=697351

Review-Url: https://codereview.chromium.org/2730773003
Cr-Commit-Position: refs/heads/master@{#454801}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a8931b10c979daa46b663e4ab40...
==========

[commit-bot: I haz the power, 2017-03-05 23:45:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a8931b10c979daa46b663e4ab40...