Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2725273002: Rename ScrollableArea fields and methods *Widget* to ...FrameViewBase... (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, Eric Willigers, kinuko+watch, mac-reviews_chromium.org, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScrollableArea fields and methods *Widget* to ...FrameViewBase... BUG=697351 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2725273002 Cr-Commit-Position: refs/heads/master@{#454806} Committed: https://chromium.googlesource.com/chromium/src/+/f82c6edf451db714b211a7c92b9c1ca3547ab0ec

Patch Set 1 #

Patch Set 2 : Rename ScrollableArea *Widget* to ...FrameViewBase... #

Patch Set 3 : Rename ScrollableArea *Widget* to ...FrameViewBase... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -46 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 5 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 1 chunk +15 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
joelhockey
3 years, 9 months ago (2017-03-03 06:46:28 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-03 19:01:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725273002/40001
3 years, 9 months ago (2017-03-06 00:00:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f82c6edf451db714b211a7c92b9c1ca3547ab0ec
3 years, 9 months ago (2017-03-06 01:07:33 UTC) #17
howlnroar666
lgtm
3 years, 9 months ago (2017-03-06 18:54:35 UTC) #19
howlnroar666
3 years, 9 months ago (2017-03-06 19:07:58 UTC) #20
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698