Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2730633004: [CSS Typed OM] Rearrange StylePropertyMap classes to match the new spec. (Closed)

Created:
3 years, 9 months ago by meade_UTC10
Modified:
3 years, 9 months ago
Reviewers:
ikilpatrick, shans, rjwright
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, haraken, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Rearrange StylePropertyMap classes to match the new spec. The edited spec is here: https://drafts.css-houdini.org/css-typed-om/#the-stylepropertymap Broadly, the changes are: - Rename ImmutableStylePropertyMap -> StylePropertyMapReadonly - Switch StylePropertyMap to inherit from StylePropertyMapReadonly instead of the other way around - Update all references appropriately BUG=545318 Review-Url: https://codereview.chromium.org/2730633004 Cr-Commit-Position: refs/heads/master@{#456025} Committed: https://chromium.googlesource.com/chromium/src/+/83749ddd60c44dfc2c418545ae47e62b686e0cd9

Patch Set 1 #

Patch Set 2 : Rearrange StylePropertyMap classes to match the new spec #

Patch Set 3 : Update interface test expectations #

Patch Set 4 : Remove spurious : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -255 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h View 4 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/ImmutableStylePropertyMap.h View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h View 1 2 chunks +3 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp View 2 chunks +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl View 1 chunk +1 line, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h View 1 3 chunks +7 lines, -27 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.cpp View 7 chunks +13 lines, -49 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.idl View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/WindowGetComputedStyle.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/WindowGetComputedStyle.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (20 generated)
meade_UTC10
3 years, 9 months ago (2017-03-02 23:28:34 UTC) #2
ikilpatrick
lgtm
3 years, 9 months ago (2017-03-02 23:33:14 UTC) #5
meade_UTC10
3 years, 9 months ago (2017-03-07 04:46:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730633004/60001
3 years, 9 months ago (2017-03-09 05:46:09 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/397633)
3 years, 9 months ago (2017-03-09 07:56:29 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730633004/60001
3 years, 9 months ago (2017-03-10 07:30:12 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 08:56:13 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/83749ddd60c44dfc2c418545ae47...

Powered by Google App Engine
This is Rietveld 408576698