Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h

Issue 2730633004: [CSS Typed OM] Rearrange StylePropertyMap classes to match the new spec. (Closed)
Patch Set: Remove spurious : Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h
diff --git a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h
similarity index 59%
copy from third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h
copy to third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h
index cb3eb3f804b2178e5e094b29f2139694e4189644..9a60511969575146364f0920f2ff146c67f53de0 100644
--- a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h
+++ b/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef StylePropertyMap_h
-#define StylePropertyMap_h
+#ifndef StylePropertyMapReadonly_h
+#define StylePropertyMapReadonly_h
#include "bindings/core/v8/CSSStyleValueOrCSSStyleValueSequence.h"
#include "bindings/core/v8/CSSStyleValueOrCSSStyleValueSequenceOrString.h"
@@ -15,22 +15,19 @@
namespace blink {
-class ExceptionState;
-
-class CORE_EXPORT StylePropertyMap
- : public GarbageCollectedFinalized<StylePropertyMap>,
+class CORE_EXPORT StylePropertyMapReadonly
+ : public GarbageCollectedFinalized<StylePropertyMapReadonly>,
public ScriptWrappable,
public PairIterable<String, CSSStyleValueOrCSSStyleValueSequence> {
- WTF_MAKE_NONCOPYABLE(StylePropertyMap);
DEFINE_WRAPPERTYPEINFO();
+ WTF_MAKE_NONCOPYABLE(StylePropertyMapReadonly);
public:
typedef std::pair<String, CSSStyleValueOrCSSStyleValueSequence>
StylePropertyMapEntry;
- virtual ~StylePropertyMap() {}
+ virtual ~StylePropertyMapReadonly() {}
- // Accessors.
virtual CSSStyleValue* get(const String& propertyName, ExceptionState&);
virtual CSSStyleValueVector getAll(const String& propertyName,
ExceptionState&);
@@ -38,27 +35,10 @@ class CORE_EXPORT StylePropertyMap
virtual Vector<String> getProperties() = 0;
- // Modifiers.
- void set(const String& propertyName,
- CSSStyleValueOrCSSStyleValueSequenceOrString& item,
- ExceptionState&);
- void append(const String& propertyName,
- CSSStyleValueOrCSSStyleValueSequenceOrString& item,
- ExceptionState&);
- void remove(const String& propertyName, ExceptionState&);
-
- virtual void set(CSSPropertyID,
- CSSStyleValueOrCSSStyleValueSequenceOrString& item,
- ExceptionState&) = 0;
- virtual void append(CSSPropertyID,
- CSSStyleValueOrCSSStyleValueSequenceOrString& item,
- ExceptionState&) = 0;
- virtual void remove(CSSPropertyID, ExceptionState&) = 0;
-
DEFINE_INLINE_VIRTUAL_TRACE() {}
protected:
- StylePropertyMap() {}
+ StylePropertyMapReadonly() = default;
virtual CSSStyleValueVector getAllInternal(CSSPropertyID) = 0;
virtual CSSStyleValueVector getAllInternal(

Powered by Google App Engine
This is Rietveld 408576698