Moves FindDisplayIndexContainingPoint into display

Moves FindDisplayIndexContainingPoint into display

And makes FindDisplayNearestPoint() use it. This is needed to make the
Screen implementation used for mus match that of classic ash.

BUG=693114
TEST=none
R=kylechar@chromium.org

Review-Url: https://codereview.chromium.org/2730413002
Cr-Commit-Position: refs/heads/master@{#454913}
Committed: https://chromium.googlesource.com/chromium/src/+/cdafce67dcb2d02d5ab5cbba79e98cc8b5e37a7b

[sky, 2017-03-06 17:07:38]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 17:07:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-06 17:08:25]

https://codereview.chromium.org/2730413002/diff/20001/ui/display/screen_base.cc
File ui/display/screen_base.cc (right):

https://codereview.chromium.org/2730413002/diff/20001/ui/display/screen_base....
ui/display/screen_base.cc:62: return
GetDisplayNearestPoint(match_rect.origin());
This matches what ScreenAsh does.

[kylechar, 2017-03-06 18:00:20]

lgtm with one comment.

https://codereview.chromium.org/2730413002/diff/20001/ui/display/display_find...
File ui/display/display_finder.h (right):

https://codereview.chromium.org/2730413002/diff/20001/ui/display/display_find...
ui/display/display_finder.h:34: DISPLAY_EXPORT int
FindDisplayIndexContainingPoint(
Would it be "more" correct to return an iterator into |displays| here? Not that
there would ever be more more than INT_MAX displays in reality .

[sky, 2017-03-06 18:22:00]

Take another look?

https://codereview.chromium.org/2730413002/diff/20001/ui/display/display_find...
File ui/display/display_finder.h (right):

https://codereview.chromium.org/2730413002/diff/20001/ui/display/display_find...
ui/display/display_finder.h:34: DISPLAY_EXPORT int
FindDisplayIndexContainingPoint(
On 2017/03/06 18:00:20, kylechar wrote:
> Would it be "more" correct to return an iterator into |displays| here? Not
that
> there would ever be more more than INT_MAX displays in reality .

I just copy/pasted the code. But I agree, an iterator makes more sense here.
Updated.

[sky, 2017-03-06 18:22:12]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 18:22:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-03-06 18:41:09]

lgtm

[sky, 2017-03-06 18:57:01]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-03-06 18:57:04]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:57:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 19:22:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488826624790420,
"parent_rev": "532c96fad9f5e4bcf277dfc5cffee840ca769001", "commit_rev":
"cdafce67dcb2d02d5ab5cbba79e98cc8b5e37a7b"}

[commit-bot: I haz the power, 2017-03-06 19:23:22]

Description was changed from

==========
Moves FindDisplayIndexContainingPoint into display

And makes FindDisplayNearestPoint() use it. This is needed to make the
Screen implementation used for mus match that of classic ash.

BUG=693114
TEST=none
R=kylechar@chromium.org
==========

to

==========
Moves FindDisplayIndexContainingPoint into display

And makes FindDisplayNearestPoint() use it. This is needed to make the
Screen implementation used for mus match that of classic ash.

BUG=693114
TEST=none
R=kylechar@chromium.org

Review-Url: https://codereview.chromium.org/2730413002
Cr-Commit-Position: refs/heads/master@{#454913}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdafce67dcb2d02d5ab5cbba79e9...
==========

[commit-bot: I haz the power, 2017-03-06 19:23:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cdafce67dcb2d02d5ab5cbba79e9...