Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: ash/display/unified_mouse_warp_controller.cc

Issue 2730413002: Moves FindDisplayIndexContainingPoint into display (Closed)
Patch Set: cleanup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/display/unified_mouse_warp_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/unified_mouse_warp_controller.cc
diff --git a/ash/display/unified_mouse_warp_controller.cc b/ash/display/unified_mouse_warp_controller.cc
index 68006a04ba246aeddde8d0b537560fda6b2892c1..c0adecb1b90070a8065d6e3d53229d56bd1cf6b2 100644
--- a/ash/display/unified_mouse_warp_controller.cc
+++ b/ash/display/unified_mouse_warp_controller.cc
@@ -15,6 +15,7 @@
#include "ui/aura/window.h"
#include "ui/aura/window_tree_host.h"
#include "ui/base/layout.h"
+#include "ui/display/display_finder.h"
#include "ui/display/display_layout.h"
#include "ui/display/manager/display_manager.h"
#include "ui/display/manager/display_manager_utilities.h"
@@ -43,12 +44,11 @@ aura::WindowTreeHost* FindMirroringWindowTreeHostFromScreenPoint(
Shell::GetInstance()
->display_manager()
->software_mirroring_display_list();
- int index = display::FindDisplayIndexContainingPoint(mirroring_display_list,
- point_in_screen);
- if (index < 0)
+ auto iter = display::FindDisplayContainingPoint(mirroring_display_list,
+ point_in_screen);
+ if (iter == mirroring_display_list.end())
return nullptr;
- return GetMirroringAshWindowTreeHostForDisplayId(
- mirroring_display_list[index].id())
+ return GetMirroringAshWindowTreeHostForDisplayId(iter->id())
->AsWindowTreeHost();
}
#endif
@@ -82,14 +82,12 @@ bool UnifiedMouseWarpController::WarpMouseCursor(ui::MouseEvent* event) {
Shell::GetInstance()
->display_manager()
->software_mirroring_display_list();
- int index = display::FindDisplayIndexContainingPoint(
- mirroring_display_list, point_in_unified_host);
- if (index >= 0) {
- const display::Display& new_display = mirroring_display_list[index];
- if (current_cursor_display_id_ != new_display.id()) {
- cursor_client->SetDisplay(new_display);
- current_cursor_display_id_ = display::kInvalidDisplayId;
- }
+ auto iter = display::FindDisplayContainingPoint(mirroring_display_list,
+ point_in_unified_host);
+ if (iter != mirroring_display_list.end() &&
+ current_cursor_display_id_ != iter->id()) {
+ cursor_client->SetDisplay(*iter);
+ current_cursor_display_id_ = display::kInvalidDisplayId;
}
}
}
« no previous file with comments | « no previous file | ash/display/unified_mouse_warp_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698