Remove FrameHost::overscrollController() methods

Remove FrameHost::overscrollController() methods

Remove FrameHost::overscrollController() methods, since these can now
call overscrollController() directly in Page.

BUG=691794
Review-Url: https://codereview.chromium.org/2730313002
Cr-Commit-Position: refs/heads/master@{#457670}
Committed: https://chromium.googlesource.com/chromium/src/+/92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0

[sashab, 2017-03-06 05:28:30]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 05:28:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 05:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 05:47:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-03-07 01:55:17]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2017-03-07 01:55:18]

Ignore failing trybots; they are compounded errors from a rebase in a previous
patch.

[sashab, 2017-03-07 02:12:25]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 02:13:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 02:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 02:18:56]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2017-03-07 03:29:52]

LGTM

https://codereview.chromium.org/2730313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/ScrollManager.cpp (right):

https://codereview.chromium.org/2730313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/ScrollManager.cpp:346: Page*
ScrollManager::page() const {

This method doesn't look so useful. Maybe shall we inline it?

[sashab, 2017-03-07 03:33:34]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2017-03-07 03:33:44]

Thanks haraken. :)

https://codereview.chromium.org/2730313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/ScrollManager.cpp (right):

https://codereview.chromium.org/2730313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/ScrollManager.cpp:346: Page*
ScrollManager::page() const {
On 2017/03/07 at 03:29:52, haraken wrote:
> This method doesn't look so useful. Maybe shall we inline it?

Good call; done.

[commit-bot: I haz the power, 2017-03-07 03:34:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:39:07]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-03-16 00:07:25]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 00:08:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:10:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:10:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sashab, 2017-03-16 00:18:04]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 00:18:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 02:06:48]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-03-16 02:06:58]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-16 02:06:59]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2730313002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-16 02:07:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:16:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 02:16:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2017-03-17 00:18:14]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-17 00:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2730313002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-17 00:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 03:10:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489709894518600,
"parent_rev": "f93cb21f636207e7f0573bf99681bfce4951e0f7", "commit_rev":
"92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0"}

[commit-bot: I haz the power, 2017-03-17 03:11:57]

Description was changed from

==========
Remove FrameHost::overscrollController() methods

Remove FrameHost::overscrollController() methods, since these can now
call overscrollController() directly in Page.

BUG=691794
==========

to

==========
Remove FrameHost::overscrollController() methods

Remove FrameHost::overscrollController() methods, since these can now
call overscrollController() directly in Page.

BUG=691794

Review-Url: https://codereview.chromium.org/2730313002
Cr-Commit-Position: refs/heads/master@{#457670}
Committed:
https://chromium.googlesource.com/chromium/src/+/92d0ed2d9d9afaf4a3ddd0e9a5b9...
==========

[commit-bot: I haz the power, 2017-03-17 03:11:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/92d0ed2d9d9afaf4a3ddd0e9a5b9...