Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: third_party/WebKit/Source/core/input/ScrollManager.cpp

Issue 2730313002: Remove FrameHost::overscrollController() methods (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/ScrollManager.cpp
diff --git a/third_party/WebKit/Source/core/input/ScrollManager.cpp b/third_party/WebKit/Source/core/input/ScrollManager.cpp
index b76b029eda839580060600d292a9a957bd1ca5bc..d4680b8dc10e565f9a01f43a7a379471173a48e9 100644
--- a/third_party/WebKit/Source/core/input/ScrollManager.cpp
+++ b/third_party/WebKit/Source/core/input/ScrollManager.cpp
@@ -8,7 +8,6 @@
#include "core/dom/DOMNodeIds.h"
#include "core/events/GestureEvent.h"
#include "core/frame/BrowserControls.h"
-#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/input/EventHandler.h"
@@ -54,10 +53,10 @@ void ScrollManager::clearGestureScrollState() {
m_deltaConsumedForScrollSequence = false;
m_currentScrollChain.clear();
- if (FrameHost* host = frameHost()) {
+ if (Page* page = m_frame->page()) {
bool resetX = true;
bool resetY = true;
- host->overscrollController().resetAccumulated(resetX, resetY);
+ page->overscrollController().resetAccumulated(resetX, resetY);
}
}
@@ -309,9 +308,8 @@ WebInputEventResult ScrollManager::handleGestureScrollUpdate(
if ((!m_previousGestureScrolledElement ||
!isViewportScrollingElement(*m_previousGestureScrolledElement)) &&
- frameHost())
- frameHost()->overscrollController().resetAccumulated(didScrollX,
- didScrollY);
+ page())
+ page()->overscrollController().resetAccumulated(didScrollX, didScrollY);
if (didScrollX || didScrollY) {
setFrameWasScrolledByUser();
@@ -345,11 +343,8 @@ WebInputEventResult ScrollManager::handleGestureScrollEnd(
return WebInputEventResult::NotHandled;
}
-FrameHost* ScrollManager::frameHost() const {
- if (!m_frame->page())
- return nullptr;
-
- return &m_frame->page()->frameHost();
+Page* ScrollManager::page() const {
+ return m_frame->page();
}
WebInputEventResult ScrollManager::passScrollGestureEvent(

Powered by Google App Engine
This is Rietveld 408576698