Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2730213002: Clean up dependencies of //ios/chrome/browser/browser_state. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkl (ping after 24h if needed), net-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up dependencies of //ios/chrome/browser/browser_state. Remove unused include from chrome_browser_state.mm and extract net_types.h to a separate target to remove a circular dependency between //ios/chrome/browser/{browser_state,net} targets. BUG=None Review-Url: https://codereview.chromium.org/2730213002 Cr-Commit-Position: refs/heads/master@{#454748} Committed: https://chromium.googlesource.com/chromium/src/+/409ec2dcbbdab8f2eb6666930a92a569c4a14155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M ios/chrome/browser/browser_state/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/net/BUILD.gn View 2 chunks +14 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-03-04 01:10:30 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-04 01:14:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730213002/1
3 years, 9 months ago (2017-03-04 01:39:30 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 02:07:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/409ec2dcbbdab8f2eb6666930a92...

Powered by Google App Engine
This is Rietveld 408576698