Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Issue 2727353006: Introduce BrowserList and Browser classes for iOS. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce BrowserList and Browser classes for iOS. Browser will lives between a ChromeBrowserState and a WebStateList and hold information relative to the state of a tab strip UI while BrowserList will tie a list of Browsers to a ChromeBrowserState. Add packed resources to ios_clean_chrome_unittests (for the moment include all resources used by ios_chrome_unittests until there are specific resources for //ios/clean) as they are required to create a ChromeBrowserState. Add missing ARC header guards to web_state_list_unittest.mm. BUG=None Review-Url: https://codereview.chromium.org/2727353006 Cr-Commit-Position: refs/heads/master@{#454944} Committed: https://chromium.googlesource.com/chromium/src/+/0c95a39f945f929bd311df10b741159f9d8b1d72

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -0 lines) Patch
A ios/clean/chrome/browser/model/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/clean/chrome/browser/model/browser.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/clean/chrome/browser/model/browser.mm View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/clean/chrome/browser/model/browser_list.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ios/clean/chrome/browser/model/browser_list.mm View 1 1 chunk +64 lines, -0 lines 0 comments Download
A ios/clean/chrome/browser/model/browser_list_unittest.mm View 1 chunk +72 lines, -0 lines 0 comments Download
M ios/clean/chrome/test/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M ios/shared/chrome/browser/tabs/web_state_list_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-03-04 01:11:24 UTC) #3
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2727353006/diff/1/ios/clean/chrome/browser/model/browser_list.mm File ios/clean/chrome/browser/model/browser_list.mm (right): https://codereview.chromium.org/2727353006/diff/1/ios/clean/chrome/browser/model/browser_list.mm#newcode49 ios/clean/chrome/browser/model/browser_list.mm:49: } Blank line after.
3 years, 9 months ago (2017-03-04 01:29:49 UTC) #5
rohitrao (ping after 24h)
I'm going to eventually propose that we only allow code in ios/clean/chrome/browser/ui, and move all ...
3 years, 9 months ago (2017-03-04 01:31:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727353006/20001
3 years, 9 months ago (2017-03-06 19:20:37 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:37:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0c95a39f945f929bd311df10b741...

Powered by Google App Engine
This is Rietveld 408576698