Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2729823002: Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange (Closed)
Patch Set: 2017-03-02T16:28:37 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index 756813bb56d2e51bd0dda87e398ce4ec71a50302..c391b8aa877e5c0354e941a6e0f0e56688ea8acd 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -2076,7 +2076,8 @@ static String valueFormatBlock(LocalFrame& frame, Event*) {
if (!selection.isNonOrphanedCaretOrRange() || !selection.isContentEditable())
return "";
Element* formatBlockElement =
- FormatBlockCommand::elementForFormatBlockCommand(firstRangeOf(selection));
Xiaocheng 2017/03/02 20:21:05 This patch has conflict with https://codereview.ch
yosin_UTC9 2017/03/09 05:18:40 The patch is committed. There is no conflict anymo
+ FormatBlockCommand::elementForFormatBlockCommand(
+ firstEphemeralRangeOf(selection));
if (!formatBlockElement)
return "";
return formatBlockElement->localName();

Powered by Google App Engine
This is Rietveld 408576698