Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2736763002: [DevTools] Save connected worker ids to send "detached" notification on restore. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Save connected worker ids to send "detached" notification on restore. So far we used MainFrameNavigated for that, which is unfortunate. Now we store all worker ids reported to frontend in backend state, so that we can report them as disconnected on cross-process navigation. BUG=none Review-Url: https://codereview.chromium.org/2736763002 Cr-Commit-Position: refs/heads/master@{#455332} Committed: https://chromium.googlesource.com/chromium/src/+/3ce2eb3e3bfb42a0147b651a3d4e191285c4a3ec

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : test result #

Messages

Total messages: 29 (15 generated)
dgozman
What do you think about this approach?
3 years, 9 months ago (2017-03-06 19:14:50 UTC) #2
pfeldman
lgtm
3 years, 9 months ago (2017-03-06 19:25:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736763002/20001
3 years, 9 months ago (2017-03-06 19:30:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/394900)
3 years, 9 months ago (2017-03-06 21:05:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736763002/40001
3 years, 9 months ago (2017-03-06 22:02:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/378691)
3 years, 9 months ago (2017-03-07 00:00:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736763002/40001
3 years, 9 months ago (2017-03-07 00:33:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/378889)
3 years, 9 months ago (2017-03-07 03:53:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736763002/40001
3 years, 9 months ago (2017-03-07 06:09:35 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379273)
3 years, 9 months ago (2017-03-07 08:38:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736763002/40001
3 years, 9 months ago (2017-03-07 16:02:50 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/396150)
3 years, 9 months ago (2017-03-07 19:24:11 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736763002/40001
3 years, 9 months ago (2017-03-07 19:32:08 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:47:18 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3ce2eb3e3bfb42a0147b651a3d4e...

Powered by Google App Engine
This is Rietveld 408576698