Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.cpp

Issue 2729613008: [instrumentation] Introduce InspectorTraceEvents agent (Closed)
Patch Set: all done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/PingLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/PingLoader.cpp b/third_party/WebKit/Source/core/loader/PingLoader.cpp
index 6ecfdf66f5e4684f30a39bca7edbf71143ebc5f0..e9cddb9b2385cf0f7c36e00878fa6207edcae0d6 100644
--- a/third_party/WebKit/Source/core/loader/PingLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/PingLoader.cpp
@@ -342,9 +342,6 @@ bool PingLoaderImpl::willFollowRedirect(
void PingLoaderImpl::didReceiveResponse(const WebURLResponse& response) {
if (frame()) {
- TRACE_EVENT1(
- "devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true, 0, 0));
const ResourceResponse& resourceResponse = response.toResourceResponse();
probe::didReceiveResourceResponse(frame(), m_identifier, 0,
resourceResponse, 0);
@@ -354,46 +351,30 @@ void PingLoaderImpl::didReceiveResponse(const WebURLResponse& response) {
}
void PingLoaderImpl::didReceiveData(const char*, int dataLength) {
- if (frame()) {
- TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true,
- dataLength, 0));
+ if (frame())
didFailLoading(frame());
- }
dispose();
}
void PingLoaderImpl::didFinishLoading(double,
int64_t,
int64_t encodedDataLength) {
- if (frame()) {
- TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true,
- encodedDataLength, 0));
+ if (frame())
didFailLoading(frame());
- }
dispose();
}
void PingLoaderImpl::didFail(const WebURLError& resourceError,
int64_t,
int64_t encodedDataLength) {
- if (frame()) {
- TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true,
- encodedDataLength, 0));
+ if (frame())
didFailLoading(frame());
- }
dispose();
}
void PingLoaderImpl::timeout(TimerBase*) {
- if (frame()) {
- TRACE_EVENT1(
- "devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true, 0, 0));
+ if (frame())
didFailLoading(frame());
- }
dispose();
}
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698