Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2729613003: Revert of Change CHECK into DCHECK. (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change CHECK into DCHECK. (patchset #1 id:1 of https://codereview.chromium.org/2721393002/ ) Reason for revert: (per discussion, I was using this to get a signal. I'll send a cl to fix) Original issue's description: > Change CHECK into DCHECK. > > Code in the browser process should not be doing a CHECK based on data > coming from the renderer process, as this allows a compromised renderer > to trivially kill the whole browser. > > BUG=688425 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2721393002 > Cr-Commit-Position: refs/heads/master@{#454047} > Committed: https://chromium.googlesource.com/chromium/src/+/43f7ab4d121be7ad05f31728ccc130d500232031 TBR=creis@chromium.org,nasko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688425 Review-Url: https://codereview.chromium.org/2729613003 Cr-Commit-Position: refs/heads/master@{#454058} Committed: https://chromium.googlesource.com/chromium/src/+/494a3b618ecf62e96f14c195a0d2234b20db785c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
jam
Created Revert of Change CHECK into DCHECK.
3 years, 9 months ago (2017-03-01 22:03:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729613003/1
3 years, 9 months ago (2017-03-01 22:04:06 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:08:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/494a3b618ecf62e96f14c195a0d2...

Powered by Google App Engine
This is Rietveld 408576698