Change CHECK into DCHECK.

Change CHECK into DCHECK.

Code in the browser process should not be doing a CHECK based on data
coming from the renderer process, as this allows a compromised renderer
to trivially kill the whole browser.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2721393002
Cr-Commit-Position: refs/heads/master@{#454047}
Committed: https://chromium.googlesource.com/chromium/src/+/43f7ab4d121be7ad05f31728ccc130d500232031

[nasko, 2017-03-01 17:56:34]

Description was changed from

==========
Change CHECK into DCHECK.

Code in the browser process should not be doing a CHECK based on data
coming from the renderer process, as this allows a compromised renderer
to trivially kill the whole browser.

BUG=688425
==========

to

==========
Change CHECK into DCHECK.

Code in the browser process should not be doing a CHECK based on data
coming from the renderer process, as this allows a compromised renderer
to trivially kill the whole browser.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2017-03-01 17:57:54]

nasko@chromium.org changed reviewers:
+ jam@chromium.org

[nasko, 2017-03-01 17:57:54]

Hey John,
Do you mind stamping this CL for me?
Thanks!
Nasko

[nasko, 2017-03-01 20:08:46]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:09:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:08:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:08:43]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2017-03-01 21:40:21]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2017-03-01 21:40:22]

LGTM.  Let's continue to investigate a better fix via https://crbug.com/596707.

[nasko, 2017-03-01 21:41:58]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:42:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:47:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488404518530880, "parent_rev":
"6246fbb36f94bb041f427d1f972cd3fd41dd40ff", "commit_rev":
"43f7ab4d121be7ad05f31728ccc130d500232031"}

[commit-bot: I haz the power, 2017-03-01 21:48:27]

Description was changed from

==========
Change CHECK into DCHECK.

Code in the browser process should not be doing a CHECK based on data
coming from the renderer process, as this allows a compromised renderer
to trivially kill the whole browser.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change CHECK into DCHECK.

Code in the browser process should not be doing a CHECK based on data
coming from the renderer process, as this allows a compromised renderer
to trivially kill the whole browser.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2721393002
Cr-Commit-Position: refs/heads/master@{#454047}
Committed:
https://chromium.googlesource.com/chromium/src/+/43f7ab4d121be7ad05f31728ccc1...
==========

[commit-bot: I haz the power, 2017-03-01 21:48:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43f7ab4d121be7ad05f31728ccc1...

[jam, 2017-03-01 22:03:20]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2729613003/ by jam@chromium.org.

The reason for reverting is: (per discussion, I was using this to get a signal.
I'll send a cl to fix).