Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2729603005: Move m_overscrollController to Page (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move m_overscrollController to Page Move m_overscrollController to Page from FrameHost. This is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2729603005 Cr-Commit-Position: refs/heads/master@{#457029} Committed: https://chromium.googlesource.com/chromium/src/+/05e8c5485ad41543721a89009285d8b7feb9a6f4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fixed small compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 2 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
sashab
3 years, 9 months ago (2017-03-02 06:20:44 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-02 07:27:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729603005/20001
3 years, 9 months ago (2017-03-14 00:19:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/228050) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-03-14 00:33:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729603005/40001
3 years, 9 months ago (2017-03-15 04:18:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729603005/60001
3 years, 9 months ago (2017-03-15 04:23:41 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 08:11:46 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/05e8c5485ad41543721a89009285...

Powered by Google App Engine
This is Rietveld 408576698