Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2729603005: Move m_overscrollController to Page (Closed)
Patch Set: Fixed small compile error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 class ContextMenuClient; 53 class ContextMenuClient;
54 class ContextMenuController; 54 class ContextMenuController;
55 class Document; 55 class Document;
56 class DragCaret; 56 class DragCaret;
57 class DragController; 57 class DragController;
58 class EditorClient; 58 class EditorClient;
59 class EventHandlerRegistry; 59 class EventHandlerRegistry;
60 class FocusController; 60 class FocusController;
61 class Frame; 61 class Frame;
62 class FrameHost; 62 class FrameHost;
63 class OverscrollController;
63 struct PageScaleConstraints; 64 struct PageScaleConstraints;
64 class PageScaleConstraintsSet; 65 class PageScaleConstraintsSet;
65 class PluginData; 66 class PluginData;
66 class PointerLockController; 67 class PointerLockController;
67 class ScopedPageSuspender; 68 class ScopedPageSuspender;
68 class ScrollingCoordinator; 69 class ScrollingCoordinator;
69 class Settings; 70 class Settings;
70 class ConsoleMessageStorage; 71 class ConsoleMessageStorage;
71 class SpellCheckerClient; 72 class SpellCheckerClient;
72 class TopDocumentRootScrollerController; 73 class TopDocumentRootScrollerController;
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 const ConsoleMessageStorage& consoleMessageStorage() const; 198 const ConsoleMessageStorage& consoleMessageStorage() const;
198 199
199 EventHandlerRegistry& eventHandlerRegistry(); 200 EventHandlerRegistry& eventHandlerRegistry();
200 const EventHandlerRegistry& eventHandlerRegistry() const; 201 const EventHandlerRegistry& eventHandlerRegistry() const;
201 202
202 TopDocumentRootScrollerController& globalRootScrollerController() const; 203 TopDocumentRootScrollerController& globalRootScrollerController() const;
203 204
204 VisualViewport& visualViewport(); 205 VisualViewport& visualViewport();
205 const VisualViewport& visualViewport() const; 206 const VisualViewport& visualViewport() const;
206 207
208 OverscrollController& overscrollController();
209 const OverscrollController& overscrollController() const;
210
207 void setTabKeyCyclesThroughElements(bool b) { 211 void setTabKeyCyclesThroughElements(bool b) {
208 m_tabKeyCyclesThroughElements = b; 212 m_tabKeyCyclesThroughElements = b;
209 } 213 }
210 bool tabKeyCyclesThroughElements() const { 214 bool tabKeyCyclesThroughElements() const {
211 return m_tabKeyCyclesThroughElements; 215 return m_tabKeyCyclesThroughElements;
212 } 216 }
213 217
214 // Suspension is used to implement the "Optionally, pause while waiting for 218 // Suspension is used to implement the "Optionally, pause while waiting for
215 // the user to acknowledge the message" step of simple dialog processing: 219 // the user to acknowledge the message" step of simple dialog processing:
216 // https://html.spec.whatwg.org/multipage/webappapis.html#simple-dialogs 220 // https://html.spec.whatwg.org/multipage/webappapis.html#simple-dialogs
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 const Member<ContextMenuController> m_contextMenuController; 292 const Member<ContextMenuController> m_contextMenuController;
289 const std::unique_ptr<PageScaleConstraintsSet> m_pageScaleConstraintsSet; 293 const std::unique_ptr<PageScaleConstraintsSet> m_pageScaleConstraintsSet;
290 const Member<PointerLockController> m_pointerLockController; 294 const Member<PointerLockController> m_pointerLockController;
291 Member<ScrollingCoordinator> m_scrollingCoordinator; 295 Member<ScrollingCoordinator> m_scrollingCoordinator;
292 const Member<BrowserControls> m_browserControls; 296 const Member<BrowserControls> m_browserControls;
293 const Member<ConsoleMessageStorage> m_consoleMessageStorage; 297 const Member<ConsoleMessageStorage> m_consoleMessageStorage;
294 const Member<EventHandlerRegistry> m_eventHandlerRegistry; 298 const Member<EventHandlerRegistry> m_eventHandlerRegistry;
295 const Member<TopDocumentRootScrollerController> 299 const Member<TopDocumentRootScrollerController>
296 m_globalRootScrollerController; 300 m_globalRootScrollerController;
297 const Member<VisualViewport> m_visualViewport; 301 const Member<VisualViewport> m_visualViewport;
302 const Member<OverscrollController> m_overscrollController;
298 303
299 // Typically, the main frame and Page should both be owned by the embedder, 304 // Typically, the main frame and Page should both be owned by the embedder,
300 // which must call Page::willBeDestroyed() prior to destroying Page. This 305 // which must call Page::willBeDestroyed() prior to destroying Page. This
301 // call detaches the main frame and clears this pointer, thus ensuring that 306 // call detaches the main frame and clears this pointer, thus ensuring that
302 // this field only references a live main frame. 307 // this field only references a live main frame.
303 // 308 //
304 // However, there are several locations (InspectorOverlay, SVGImage, and 309 // However, there are several locations (InspectorOverlay, SVGImage, and
305 // WebPagePopupImpl) which don't hold a reference to the main frame at all 310 // WebPagePopupImpl) which don't hold a reference to the main frame at all
306 // after creating it. These are still safe because they always create a 311 // after creating it. These are still safe because they always create a
307 // Frame with a FrameView. FrameView and Frame hold references to each 312 // Frame with a FrameView. FrameView and Frame hold references to each
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 // Page. 350 // Page.
346 // FIXME: Most of the members of Page should move onto FrameHost. 351 // FIXME: Most of the members of Page should move onto FrameHost.
347 Member<FrameHost> m_frameHost; 352 Member<FrameHost> m_frameHost;
348 }; 353 };
349 354
350 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>; 355 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>;
351 356
352 } // namespace blink 357 } // namespace blink
353 358
354 #endif // Page_h 359 #endif // Page_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.cpp ('k') | third_party/WebKit/Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698