Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 2729563002: predictors: Disable URL-based learning by default. (Closed)

Created:
3 years, 9 months ago by alexilin
Modified:
3 years, 9 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Disable URL-based learning by default. This CL disables URL-based learning by default and allows to enable it through a finch parameter. BUG=631966 Review-Url: https://codereview.chromium.org/2729563002 Cr-Commit-Position: refs/heads/master@{#453996} Committed: https://chromium.googlesource.com/chromium/src/+/2684ef71713dde49b5708d3944eb674ca8d4f24f

Patch Set 1 #

Total comments: 3

Patch Set 2 : Get rid of URL-only. #

Total comments: 2

Patch Set 3 : Return the comment. #

Patch Set 4 : Fix missed initialization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -36 lines) Patch
M chrome/browser/predictors/resource_prefetch_common.h View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.cc View 1 2 3 4 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common_unittest.cc View 1 4 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 5 chunks +19 lines, -24 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
alexilin
Hi, Benoit! Please, review this ASAP to have time to land it before M58 branch ...
3 years, 9 months ago (2017-03-01 12:57:57 UTC) #3
Benoit L
https://codereview.chromium.org/2729563002/diff/1/chrome/browser/predictors/resource_prefetch_common.cc File chrome/browser/predictors/resource_prefetch_common.cc (right): https://codereview.chromium.org/2729563002/diff/1/chrome/browser/predictors/resource_prefetch_common.cc#newcode66 chrome/browser/predictors/resource_prefetch_common.cc:66: std::string key_type_value = base::GetFieldTrialParamValueByFeature( Do we really want URL-only? ...
3 years, 9 months ago (2017-03-01 16:04:42 UTC) #4
alexilin
https://codereview.chromium.org/2729563002/diff/1/chrome/browser/predictors/resource_prefetch_common.cc File chrome/browser/predictors/resource_prefetch_common.cc (right): https://codereview.chromium.org/2729563002/diff/1/chrome/browser/predictors/resource_prefetch_common.cc#newcode66 chrome/browser/predictors/resource_prefetch_common.cc:66: std::string key_type_value = base::GetFieldTrialParamValueByFeature( On 2017/03/01 16:04:41, Benoit L ...
3 years, 9 months ago (2017-03-01 16:55:56 UTC) #6
Benoit L
thanks, lgtm. https://codereview.chromium.org/2729563002/diff/20001/chrome/browser/predictors/resource_prefetch_common.h File chrome/browser/predictors/resource_prefetch_common.h (left): https://codereview.chromium.org/2729563002/diff/20001/chrome/browser/predictors/resource_prefetch_common.h#oldcode80 chrome/browser/predictors/resource_prefetch_common.h:80: PREFETCHING_FOR_NAVIGATION = 1 << 2, // Also ...
3 years, 9 months ago (2017-03-01 17:07:01 UTC) #7
alexilin
https://codereview.chromium.org/2729563002/diff/20001/chrome/browser/predictors/resource_prefetch_common.h File chrome/browser/predictors/resource_prefetch_common.h (left): https://codereview.chromium.org/2729563002/diff/20001/chrome/browser/predictors/resource_prefetch_common.h#oldcode80 chrome/browser/predictors/resource_prefetch_common.h:80: PREFETCHING_FOR_NAVIGATION = 1 << 2, // Also enables LEARNING. ...
3 years, 9 months ago (2017-03-01 17:18:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729563002/40001
3 years, 9 months ago (2017-03-01 17:19:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/331589) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-01 17:42:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729563002/60001
3 years, 9 months ago (2017-03-01 17:52:53 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 19:27:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2684ef71713dde49b5708d3944eb...

Powered by Google App Engine
This is Rietveld 408576698