predictors: Disable URL-based learning by default.

chrome/browser/predictors/resource_prefetch_common_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 
-#include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/net/prediction_options.h"
 #include "chrome/browser/predictors/resource_prefetch_common.h"
 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/prefs/pref_service.h"
 #include "components/variations/variations_params_manager.h"
@@ skipping 66 matching lines @@
       profile_(new TestingProfile()) { }
 
 TEST_F(ResourcePrefetchCommonTest, IsDisabledByDefault) {
   ResourcePrefetchPredictorConfig config;
   EXPECT_FALSE(
       IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
 
   EXPECT_FALSE(config.IsLearningEnabled());
   EXPECT_FALSE(config.IsPrefetchingEnabledForOrigin(profile_.get(),
                                                     PrefetchOrigin::EXTERNAL));
-  EXPECT_FALSE(config.IsLearningEnabled());

[alexilin, 2017/03/01 12:57:57]

Second check of the same thing. Looks like a bug.

+  EXPECT_FALSE(config.IsPrefetchingEnabledForOrigin(
+      profile_.get(), PrefetchOrigin::NAVIGATION));
 
   TestIsDefaultExtraConfig(config);
 }
 
 TEST_F(ResourcePrefetchCommonTest, EnableLearning) {
   variations::testing::VariationParamsManager params_manager(
       "dummy-trial", {{kModeParamName, kLearningMode}},
       {kSpeculativeResourcePrefetchingFeatureName});
 
   ResourcePrefetchPredictorConfig config;
@@ skipping 20 matching lines @@
       {kSpeculativeResourcePrefetchingFeatureName});
 
   ResourcePrefetchPredictorConfig config;
   EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
   TestIsPrefetchEnabledForOrigin(config, PrefetchOrigin::EXTERNAL);
   EXPECT_FALSE(config.IsPrefetchingEnabledForOrigin(
       profile_.get(), PrefetchOrigin::NAVIGATION));
   TestIsDefaultExtraConfig(config);
 }
 
+TEST_F(ResourcePrefetchCommonTest, EnableUrlLearning) {
+  variations::testing::VariationParamsManager params_manager(
+      "dummy-trial",
+      {{kModeParamName, kLearningMode}, {kKeyTypeParamName, kUrlKeyType}},
+      {kSpeculativeResourcePrefetchingFeatureName});
+
+  ResourcePrefetchPredictorConfig config;
+  EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
+  TestIsPrefetchLearning(config);
+  EXPECT_TRUE(config.IsURLLearningEnabled());
+  EXPECT_FALSE(config.IsHostLearningEnabled());
+  TestIsDefaultExtraConfig(config);
+}
+
+TEST_F(ResourcePrefetchCommonTest, EnableHostLearning) {
+  variations::testing::VariationParamsManager params_manager(
+      "dummy-trial",
+      {{kModeParamName, kLearningMode}, {kKeyTypeParamName, kHostKeyType}},
+      {kSpeculativeResourcePrefetchingFeatureName});
+
+  ResourcePrefetchPredictorConfig config;
+  EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
+  TestIsPrefetchLearning(config);
+  EXPECT_FALSE(config.IsURLLearningEnabled());
+  EXPECT_TRUE(config.IsHostLearningEnabled());
+  TestIsDefaultExtraConfig(config);
+}
+
+TEST_F(ResourcePrefetchCommonTest, EnableBothLearning) {
+  variations::testing::VariationParamsManager params_manager(
+      "dummy-trial",
+      {{kModeParamName, kLearningMode}, {kKeyTypeParamName, kBothKeyType}},
+      {kSpeculativeResourcePrefetchingFeatureName});
+
+  ResourcePrefetchPredictorConfig config;
+  EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
+  TestIsPrefetchLearning(config);
+  EXPECT_TRUE(config.IsURLLearningEnabled());
+  EXPECT_TRUE(config.IsHostLearningEnabled());
+  TestIsDefaultExtraConfig(config);
+}
+
 // Verifies whether prefetching is disabled according to the network type. But
 // learning should not be disabled by network.
 TEST_F(ResourcePrefetchCommonTest, RespectsNetworkSettings) {
   variations::testing::VariationParamsManager params_manager(
       "dummy-trial", {{kModeParamName, kPrefetchingMode}},
       {kSpeculativeResourcePrefetchingFeatureName});
 
   ResourcePrefetchPredictorConfig config;
   EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
   TestIsPrefetchEnabledForOrigin(config, PrefetchOrigin::EXTERNAL);
@@ skipping 20 matching lines @@
     TestIsPrefetchLearning(config);
   }
   {
     std::unique_ptr<NetworkChangeNotifier> mock(
         new MockNetworkChangeNotifier4G);
     TestIsPrefetchLearning(config);
   }
 }
 
 }  // namespace predictors