Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2729533002: Adjust behavior of control buttons of notifications. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, Peter Beverloo, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust behavior of control buttons of notifications. - Change the background of buttons to (#FFF, 0.9a). - Fix typo in ArcCustomNotificationView. - Make control buttons visible only when mouse cursor hovers on a notification or one of control buttons is focused. - Set ink drop animations for control buttons. BUG=b/35260628 Review-Url: https://codereview.chromium.org/2729533002 Cr-Commit-Position: refs/heads/master@{#454107} Committed: https://chromium.googlesource.com/chromium/src/+/fff4cd8691021ffe01c99480a33a14d06e3eae22

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : Add unimplemented method to TestContentViewDelegate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -12 lines) Patch
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M ui/message_center/views/custom_notification_content_view_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/message_center_bubble.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 1 5 chunks +11 lines, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 3 chunks +23 lines, -1 line 0 comments Download
M ui/message_center/views/message_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/notification_view.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 3 chunks +29 lines, -0 lines 0 comments Download
M ui/message_center/views/padded_button.h View 2 chunks +7 lines, -1 line 0 comments Download
M ui/message_center/views/padded_button.cc View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 20 (16 generated)
yhanada
Hi yoshiki@, PTAL.
3 years, 9 months ago (2017-03-01 08:17:00 UTC) #3
yoshiki
lgtm
3 years, 9 months ago (2017-03-01 09:02:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729533002/40001
3 years, 9 months ago (2017-03-01 23:59:14 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 00:07:13 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fff4cd8691021ffe01c99480a33a...

Powered by Google App Engine
This is Rietveld 408576698