Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: ui/arc/notification/arc_custom_notification_view.cc

Issue 2729533002: Adjust behavior of control buttons of notifications. (Closed)
Patch Set: Add unimplemented method to TestContentViewDelegate Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/arc/notification/arc_custom_notification_view.cc
diff --git a/ui/arc/notification/arc_custom_notification_view.cc b/ui/arc/notification/arc_custom_notification_view.cc
index b622f420755237ce93700d03a26ce68e2073049f..2c3babb8a15555eaa7f269a013f270ff454ee044 100644
--- a/ui/arc/notification/arc_custom_notification_view.cc
+++ b/ui/arc/notification/arc_custom_notification_view.cc
@@ -167,13 +167,17 @@ class ArcCustomNotificationView::ContentViewDelegate
void RequestFocusOnCloseButton() override {
if (owner_->close_button_)
owner_->close_button_->RequestFocus();
- owner_->UpdateControlButtonsVisiblity();
+ owner_->UpdateControlButtonsVisibility();
}
bool IsPinned() const override {
return owner_->item_->pinned();
}
+ void UpdateControlButtonsVisibility() override {
+ owner_->UpdateControlButtonsVisibility();
+ }
+
private:
ArcCustomNotificationView* const owner_;
@@ -188,12 +192,12 @@ class ArcCustomNotificationView::ControlButton
void OnFocus() override {
message_center::PaddedButton::OnFocus();
- owner_->UpdateControlButtonsVisiblity();
+ owner_->UpdateControlButtonsVisibility();
}
void OnBlur() override {
message_center::PaddedButton::OnBlur();
- owner_->UpdateControlButtonsVisiblity();
+ owner_->UpdateControlButtonsVisibility();
}
private:
@@ -325,7 +329,7 @@ void ArcCustomNotificationView::UpdatePreferredSize() {
SetPreferredSize(preferred_size);
}
-void ArcCustomNotificationView::UpdateControlButtonsVisiblity() {
+void ArcCustomNotificationView::UpdateControlButtonsVisibility() {
if (!surface_ || !floating_control_buttons_widget_)
return;
@@ -445,7 +449,7 @@ void ArcCustomNotificationView::Layout() {
control_buttons_bounds.set_width(buttons_width);
floating_control_buttons_widget_->SetBounds(control_buttons_bounds);
- UpdateControlButtonsVisiblity();
+ UpdateControlButtonsVisibility();
ash::wm::SnapWindowToPixelBoundary(surface_->window());
}
@@ -478,11 +482,11 @@ void ArcCustomNotificationView::OnGestureEvent(ui::GestureEvent* event) {
}
void ArcCustomNotificationView::OnMouseEntered(const ui::MouseEvent&) {
- UpdateControlButtonsVisiblity();
+ UpdateControlButtonsVisibility();
}
void ArcCustomNotificationView::OnMouseExited(const ui::MouseEvent&) {
- UpdateControlButtonsVisiblity();
+ UpdateControlButtonsVisibility();
}
void ArcCustomNotificationView::OnFocus() {

Powered by Google App Engine
This is Rietveld 408576698