Network traffic annotation added to chromium_url_request.

remoting/base/telemetry_log_writer.cc

Index: remoting/base/telemetry_log_writer.cc
diff --git a/remoting/base/telemetry_log_writer.cc b/remoting/base/telemetry_log_writer.cc
index 24360f0282cd346e9d5e30f06baa2af4dc0ab788..08aa27135870bc50c210efba388cd2141e37201f 100644
--- a/remoting/base/telemetry_log_writer.cc
+++ b/remoting/base/telemetry_log_writer.cc
@@ -9,6 +9,7 @@
 #include "base/json/json_string_value_serializer.h"
 #include "base/logging.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 
 namespace remoting {
 
@@ -68,8 +69,29 @@ void TelemetryLogWriter::SendPendingEntries() {
 void TelemetryLogWriter::PostJsonToServer(const std::string& json) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!request_);
-  request_ = request_factory_->CreateUrlRequest(UrlRequest::Type::POST,
-                                                telemetry_base_url_);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(

[Sergey Ulanov, 2017/03/17 18:59:32]

CRD_telemetry_log or something like that.

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+        semantics {
+          sender: "..."

[Sergey Ulanov, 2017/03/17 18:59:31]

"Chrome Remote Desktop"

[Ramin Halavati, 2017/04/03 10:01:24]

Done.

+          description: "..."

[Sergey Ulanov, 2017/03/17 18:59:31]

"Telemetry logs for Chrome Remote Desktop"

[Ramin Halavati, 2017/04/03 10:01:24]

Done.

+          trigger: "..."

[Sergey Ulanov, 2017/03/17 18:59:31]

"Chrome Remote Desktop is being used"

[Ramin Halavati, 2017/04/03 10:01:24]

Can it be more specific?

+          data: "..."

[Sergey Ulanov, 2017/03/17 18:59:31]

"Anonymous usage statistics"

[Ramin Halavati, 2017/04/03 10:01:24]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[Sergey Ulanov, 2017/03/17 18:59:31]

GOOGLE_OWNED_SERVICE

[Ramin Halavati, 2017/04/03 10:01:24]

Done.

+        }
+        policy {
+          cookies_allowed: false/true

[Sergey Ulanov, 2017/03/17 18:59:31]

false

[Ramin Halavati, 2017/04/03 10:01:24]

Cookies are not specifically disabled (they are enabled by default). If you
don't need them, can I create a separate CL that disables them?

[Sergey Ulanov, 2017/04/04 00:16:47]

We don't need them. Please disable.

[Ramin Halavati, 2017/04/04 07:37:18]

Done, in https://codereview.chromium.org/2792283002

+          cookies_store: "..."

[Sergey Ulanov, 2017/03/17 18:59:32]

N/A

[Ramin Halavati, 2017/04/03 10:01:24]

Acknowledged.

+          setting: "..."

[Sergey Ulanov, 2017/03/17 18:59:32]

"Block Chrome Remote Desktop"

[Ramin Halavati, 2017/04/03 10:01:24]

Done.

+          chrome_policy {
+            [POLICY_NAME] {

[Sergey Ulanov, 2017/03/17 18:59:31]

This code is currently used in the CRD app on Android, so there are not policies
to block it. The recommended way to block CRD everywhere is by DNS configuration
(documented at https://support.google.com/chrome/a/answer/2799701?hl=en)

In the future the same code will be used for the host. There is chrome policy to
disable it, but we could potentially add one (in either case the same policy
still applies).

[Ramin Halavati, 2017/04/03 10:01:24]

Done.

+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+              [POLICY_NAME]: ... //(value to disable it)
+            }
+          }
+          policy_exception_justification: "..."

[Sergey Ulanov, 2017/03/17 18:59:31]

The product is shipped separately from Chrome, except on Chrome OS.
There are other means to block this request.

[Ramin Halavati, 2017/04/03 10:01:24]

Done.

+        })");
+  request_ = request_factory_->CreateUrlRequest(
+      UrlRequest::Type::POST, telemetry_base_url_, traffic_annotation);
   if (!auth_token_.empty()) {
     request_->AddHeader("Authorization:Bearer " + auth_token_);
   }