Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2729353002: Remove webkitdropzone. (Closed)

Created:
1 year, 9 months ago by pwnall
Modified:
1 year, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Remove webkitdropzone. webkitdropzone is a prefixed version of the dropzone HTML global attribute. dropzone failed to gain traction among browser vendors, and only Blink and WebKit implement prefixed versions. Therefore, dropzone is being removed from the HTML specification in https://github.com/whatwg/html/pull/2402 The following LayoutTests, which depended on webkitdropzone, have been rewritten to use event listeners. These tests cover other drag-and-drop functionality that we still want covered. * fast/events/dropzone-001 -> fast/dnd/dropEffect-for-effectAllowed * fast/events/dropzone-002 -> fast/dnd/dropEffect-for-image * fast/events/dropzone-003 -> fast/dnd/dropEffect-for-link * fast/events/dropzone-004 -> fast/dnd/dropEffect-for-file The followng LayoutTests have been removed, because they do not cover additional functionality that we still need. * fast/events/dropzone-005 -> only covers dropzone-specific code * fast/dnd/file-drop-on-webkitdropzone-element.html -> redundant with fast/dnd/file-drag-drop-on-page.html * http/tests/dnd/file-drop-on-webkitdropzone-element.html -> redundant with fast/dnd/file-drag-drop-on-page.html BUG=688943 Review-Url: https://codereview.chromium.org/2720463002 Cr-Commit-Position: refs/heads/master@{#454488} (cherry picked from commit 798a0d0b8b42492f3acd803caa2ce0b35b8b29d2) Review-Url: https://codereview.chromium.org/2729353002 . Cr-Commit-Position: refs/branch-heads/3029@{#9} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b152fa718af332bde2004d61e5b0ecbef9653ec1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -909 lines) Patch
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html View 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-file.html View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-image.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html View 1 chunk +46 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dnd/file-drop-on-webkitdropzone-element.html View 1 chunk +0 lines, -137 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/resources/dropEffect-common.js View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/resources/greenbox.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-001.html View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-001-expected.txt View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-002.html View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-002-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-003.html View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-003-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-004.html View 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-004-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-005.html View 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-005-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/dnd/drop-file-on-webkitdropzone.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/dnd/resources/dragged-file.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 3 chunks +0 lines, -48 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
pwnall
1 year, 9 months ago (2017-03-05 06:54:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b152fa718af332bde2004d61e5b0ecbef9653ec1.

Powered by Google App Engine
This is Rietveld 408576698