Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2720463002: Remove webkitdropzone. (Closed)

Created:
3 years, 10 months ago by pwnall
Modified:
3 years, 9 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove webkitdropzone. webkitdropzone is a prefixed version of the dropzone HTML global attribute. dropzone failed to gain traction among browser vendors, and only Blink and WebKit implement prefixed versions. Therefore, dropzone is being removed from the HTML specification in https://github.com/whatwg/html/pull/2402 The following LayoutTests, which depended on webkitdropzone, have been rewritten to use event listeners. These tests cover other drag-and-drop functionality that we still want covered. * fast/events/dropzone-001 -> fast/dnd/dropEffect-for-effectAllowed * fast/events/dropzone-002 -> fast/dnd/dropEffect-for-image * fast/events/dropzone-003 -> fast/dnd/dropEffect-for-link * fast/events/dropzone-004 -> fast/dnd/dropEffect-for-file The followng LayoutTests have been removed, because they do not cover additional functionality that we still need. * fast/events/dropzone-005 -> only covers dropzone-specific code * fast/dnd/file-drop-on-webkitdropzone-element.html -> redundant with fast/dnd/file-drag-drop-on-page.html * http/tests/dnd/file-drop-on-webkitdropzone-element.html -> redundant with fast/dnd/file-drag-drop-on-page.html BUG=688943 Review-Url: https://codereview.chromium.org/2720463002 Cr-Commit-Position: refs/heads/master@{#454488} Committed: https://chromium.googlesource.com/chromium/src/+/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2

Patch Set 1 #

Patch Set 2 : Updated some test expectations. #

Patch Set 3 : Some rewritten dropzone tests, for cross-platform checks. #

Patch Set 4 : Finished rewriting dropzone tests. #

Total comments: 18

Patch Set 5 : Addressed jsbell feedback. #

Patch Set 6 : Addressed one more bit of feedback from jsbell. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -909 lines) Patch
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html View 1 2 3 4 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-file.html View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-image.html View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dnd/file-drop-on-webkitdropzone-element.html View 1 2 1 chunk +0 lines, -137 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/resources/dropEffect-common.js View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dnd/resources/greenbox.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-001.html View 1 2 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-001-expected.txt View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-002.html View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-002-expected.txt View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-003.html View 1 2 3 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-003-expected.txt View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-004.html View 1 2 3 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-004-expected.txt View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-005.html View 1 2 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/dropzone-005-expected.txt View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/dnd/drop-file-on-webkitdropzone.html View 1 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/dnd/resources/dragged-file.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 3 chunks +0 lines, -48 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 41 (29 generated)
pwnall
dcheng: Please review the changes in third_party/WebKit/Source/core -- if you're curious, also take a look ...
3 years, 9 months ago (2017-03-02 15:11:50 UTC) #15
dcheng
https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html File third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html (right): https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html#newcode72 third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html:72: dropEffectTest({ allowed: 'uninitialized', drop: 'none' }); I'm not quite ...
3 years, 9 months ago (2017-03-02 19:24:33 UTC) #18
pwnall
https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html File third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html (right): https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html#newcode72 third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html:72: dropEffectTest({ allowed: 'uninitialized', drop: 'none' }); On 2017/03/02 19:24:33, ...
3 years, 9 months ago (2017-03-02 19:57:54 UTC) #19
Steven Holte
histograms xml lgtm
3 years, 9 months ago (2017-03-02 20:25:16 UTC) #21
dcheng
lgtm https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html File third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html (right): https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html#newcode42 third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html:42: dropEffectTest({ drop: 'dummy', operation: 'copy' }); The results ...
3 years, 9 months ago (2017-03-02 20:44:49 UTC) #22
pwnall
https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html File third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html (right): https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html#newcode42 third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html:42: dropEffectTest({ drop: 'dummy', operation: 'copy' }); On 2017/03/02 20:44:49, ...
3 years, 9 months ago (2017-03-02 20:53:56 UTC) #23
jsbell
lgtm with some nits (and a couple refactor suggestions) https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html File third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html (right): https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html#newcode2 third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html:2: ...
3 years, 9 months ago (2017-03-02 22:06:46 UTC) #24
chrishtr
lgtm LGTM for api change.
3 years, 9 months ago (2017-03-02 22:32:29 UTC) #26
pwnall
Thank you very much for the thoughtful feedback and quick turnaround! https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html File third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html (right): ...
3 years, 9 months ago (2017-03-02 22:34:29 UTC) #30
pwnall
https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2720463002/diff/60001/third_party/WebKit/Source/core/frame/UseCounter.h#newcode356 third_party/WebKit/Source/core/frame/UseCounter.h:356: OBSOLETE_PrefixedHTMLElementDropzone = 490, On 2017/03/02 22:06:45, jsbell wrote: > ...
3 years, 9 months ago (2017-03-02 22:47:04 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720463002/100001
3 years, 9 months ago (2017-03-03 00:45:42 UTC) #38
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 03:07:40 UTC) #41
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/798a0d0b8b42492f3acd803caa2c...

Powered by Google App Engine
This is Rietveld 408576698