Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2729213002: [LayoutNG] Rename logical_available_size to container_size. (Closed)

Created:
3 years, 9 months ago by ikilpatrick
Modified:
3 years, 9 months ago
Reviewers:
cbiesinger, atotic
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Rename logical_available_size to container_size. From: crrev.com/2727263003 The percentage resolution size should be based off the container, and the available size should remain as-is. BUG=635619 Review-Url: https://codereview.chromium.org/2729213002 Cr-Commit-Position: refs/heads/master@{#454637} Committed: https://chromium.googlesource.com/chromium/src/+/f9aecd384eaaf9d50343b20c9a1bba61ed71f5dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ikilpatrick
I could also rename available_size to descendant_or_available_size but seemed a bit too verbose. :/
3 years, 9 months ago (2017-03-03 17:26:08 UTC) #4
cbiesinger
lgtm, thank you!
3 years, 9 months ago (2017-03-03 17:27:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729213002/1
3 years, 9 months ago (2017-03-03 18:08:03 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 18:56:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9aecd384eaaf9d50343b20c9a1b...

Powered by Google App Engine
This is Rietveld 408576698