[compiler] Simplify paramerters for spread call.

[compiler] Simplify paramerters for spread call.

The parameters for ConstructWithSpread and CallWithSpread both
contain the arity for JavaScript calls with a spread as the
last parameter and have the same functionality. Simplify them as
one parameter.

BUG=

Review-Url: https://codereview.chromium.org/2729143002
Cr-Commit-Position: refs/heads/master@{#43581}
Committed: https://chromium.googlesource.com/v8/v8/+/c41e20fcb58c636eadbe445679c0faf8f9ecbb75

[Franzi, 2017-03-03 10:04:55]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 10:04:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 10:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 10:30:28]

Dry run: This issue passed the CQ dry run.

[Franzi, 2017-03-03 10:33:17]

franzih@chromium.org changed reviewers:
+ bmeurer@chromium.org, petermarshall@chromium.org

[Franzi, 2017-03-03 10:33:18]

PTAL

[Benedikt Meurer, 2017-03-03 11:39:38]

lgtm

[petermarshall, 2017-03-03 11:41:10]

lgtm

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:99: DCHECK(IrOpcode::kJSConstructWithSpread ==
op->opcode() ||
I think the convention for == would mean that op->opcode() is on the left-hand
side here (although its the other way around for DCHECK_EQ...). Not sure though

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.h#...
src/compiler/js-operator.h:90: // Defines the arity for a JavaScript calls with
a spread as the last
Nit: Remove 'a' before JavaScript calls.

Could you also remove the 's' from 'parameters' on the line below? (my typo from
when I first put this in...)

[Franzi, 2017-03-03 11:49:45]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2017-03-03 11:49:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, petermarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2729143002/#ps20001
(title: "Address nits.")

[commit-bot: I haz the power, 2017-03-03 11:49:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-03-03 11:50:27]

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:99: DCHECK(IrOpcode::kJSConstructWithSpread ==
op->opcode() ||
On 2017/03/03 11:41:10, petermarshall wrote:
> I think the convention for == would mean that op->opcode() is on the left-hand
> side here (although its the other way around for DCHECK_EQ...). Not sure
though

Done.

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):

https://codereview.chromium.org/2729143002/diff/1/src/compiler/js-operator.h#...
src/compiler/js-operator.h:90: // Defines the arity for a JavaScript calls with
a spread as the last
On 2017/03/03 11:41:10, petermarshall wrote:
> Nit: Remove 'a' before JavaScript calls.
> 
> Could you also remove the 's' from 'parameters' on the line below? (my typo
from
> when I first put this in...)

Done.

[commit-bot: I haz the power, 2017-03-03 12:16:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488541785154500,
"parent_rev": "68d6b6c613c8641748a390a10d886859e5afa38b", "commit_rev":
"c41e20fcb58c636eadbe445679c0faf8f9ecbb75"}

[commit-bot: I haz the power, 2017-03-03 12:16:09]

Description was changed from

==========
[compiler] Simplify paramerters for spread call.

The parameters for ConstructWithSpread and CallWithSpread both
contain the arity for JavaScript calls with a spread as the
last parameter and have the same functionality. Simplify them as
one parameter.

BUG=
==========

to

==========
[compiler] Simplify paramerters for spread call.

The parameters for ConstructWithSpread and CallWithSpread both
contain the arity for JavaScript calls with a spread as the
last parameter and have the same functionality. Simplify them as
one parameter.

BUG=

Review-Url: https://codereview.chromium.org/2729143002
Cr-Commit-Position: refs/heads/master@{#43581}
Committed:
https://chromium.googlesource.com/v8/v8/+/c41e20fcb58c636eadbe445679c0faf8f9e...
==========

[commit-bot: I haz the power, 2017-03-03 12:16:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c41e20fcb58c636eadbe445679c0faf8f9e...