Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2725263003: [compiler] Rename DataPropertyParameters. (Closed)

Created:
3 years, 9 months ago by Franzi
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Rename JS operator parameters. DataPropertyParameters are not specific to StoreDataProperty. Rename it to FeedbackParameter, so it can be used for similar ICs, e.g., future CollectTypeProfile. Also, the parameter for spread calls contains just one parameter, remove the plural s. BUG= Review-Url: https://codereview.chromium.org/2725263003 Cr-Commit-Position: refs/heads/master@{#43604} Committed: https://chromium.googlesource.com/v8/v8/+/e592fc424a7452499ceef94c8d171c10c20c2e0f

Patch Set 1 #

Patch Set 2 : Use a better name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M src/compiler/js-call-reducer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-operator.h View 1 4 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/js-operator.cc View 1 5 chunks +20 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (13 generated)
Franzi
PTAL. Thanks!
3 years, 9 months ago (2017-03-03 12:26:55 UTC) #6
Franzi
Hi Benedikt, changed the parameter names again. Better? Thanks, Franzi
3 years, 9 months ago (2017-03-06 10:01:08 UTC) #10
Benedikt Meurer
LGTM.
3 years, 9 months ago (2017-03-06 10:14:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725263003/20001
3 years, 9 months ago (2017-03-06 10:17:28 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 10:19:11 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e592fc424a7452499ceef94c8d171c10c20...

Powered by Google App Engine
This is Rietveld 408576698