Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2728903002: Try x64 binary for symupload (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3026
Project:
chromium
Visibility:
Public.

Description

Try x64 binary for symupload symupload is still failing for chrome_child.dll on the 32 bit official bots. One last try of making an x64 binary instead, and then I'm going to give up. TBR=mark@chromium.org BUG=678874, 696257, 696671, 696911, 697638 Review-Url: https://codereview.chromium.org/2723233003 Cr-Commit-Position: refs/heads/master@{#454089} (cherry picked from commit 73dd82d9969add23c5070c12cdbeba8e9e3f13ff) Review-Url: https://codereview.chromium.org/2728903002 . Cr-Commit-Position: refs/branch-heads/3026@{#7} Cr-Branched-From: fe586ab75aca1b8ab839db23bceac5f621389fed-refs/heads/master@{#453454} Committed: https://chromium.googlesource.com/chromium/src/+/bf0b0926a4ad3ad196540c7a9c31c465591fc645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M breakpad/symupload.exe View Binary file 0 comments Download

Messages

Total messages: 4 (1 generated)
scottmg
Committed patchset #1 (id:1) manually as bf0b0926a4ad3ad196540c7a9c31c465591fc645.
3 years, 9 months ago (2017-03-02 02:25:51 UTC) #2
Mark Mentovai
And I thought we were done for the day. And I also thought that the ...
3 years, 9 months ago (2017-03-02 02:42:36 UTC) #3
scottmg
3 years, 9 months ago (2017-03-02 02:47:36 UTC) #4
Message was sent while issue was closed.
On 2017/03/02 02:42:36, Mark Mentovai wrote:
> And I thought we were done for the day.
> 
> And I also thought that the last one would do it for sure.
> 
> LGTM

This one was just a merge since unfortunately the last attempt was on a branch
that went out as dev.

I think. I'm not entirely sure based on the discussion in the bug.

I haven't been able to repro an OOM locally fwiw. It uses 1.5-1.7G before trying
the upload. So I do think the LargeAddressAware binary probably should have been
fine, so it's possible there's something else going wrong.

But I tried to use the binary I landed most recently on the chrome_child.dll
that failed most recently but unfortunately it worked fine. So I'm definitely
shooting in the dark here.

Powered by Google App Engine
This is Rietveld 408576698