Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2723233003: Try x64 binary for symupload (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try x64 binary for symupload symupload is still failing for chrome_child.dll on the 32 bit official bots. One last try of making an x64 binary instead, and then I'm going to give up. TBR=mark@chromium.org BUG=678874, 696257, 696671, 696911, 697638 Review-Url: https://codereview.chromium.org/2723233003 Cr-Commit-Position: refs/heads/master@{#454089} Committed: https://chromium.googlesource.com/chromium/src/+/73dd82d9969add23c5070c12cdbeba8e9e3f13ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M breakpad/symupload.exe View Binary file 0 comments Download

Messages

Total messages: 13 (7 generated)
scottmg
3 years, 9 months ago (2017-03-01 23:04:07 UTC) #2
scottmg
(I'm going to TBR this as a build fix as it's not really reviewable anyway, ...
3 years, 9 months ago (2017-03-01 23:08:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723233003/1
3 years, 9 months ago (2017-03-01 23:09:16 UTC) #8
scottmg
I realized I don't really know if msdia120 for x64 is registered on the bots, ...
3 years, 9 months ago (2017-03-01 23:18:36 UTC) #9
Mark Mentovai
LGTM, otherwise, I guess we’ll look with fresh eyes tomorrow.
3 years, 9 months ago (2017-03-01 23:19:01 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 23:19:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73dd82d9969add23c5070c12cdbe...

Powered by Google App Engine
This is Rietveld 408576698