|
|
DescriptionRemove VisualViewport::frameHost()
Remove the VisualViewport::frameHost() method, and replace it with
Remove Remove VisualViewport::page() and update callsites.
This is pre-work to remove FrameHost from VisualViewport, which is part
of the work to remove FrameHost.
BUG=691794
Review-Url: https://codereview.chromium.org/2728873002
Cr-Commit-Position: refs/heads/master@{#455637}
Committed: https://chromium.googlesource.com/chromium/src/+/23681f7f9786a74472661de74377afcf19754ab1
Patch Set 1 #Patch Set 2 : Fix compoile error #Patch Set 3 : Fixed rebase #Patch Set 4 : Rebase #
Dependent Patchsets: Messages
Total messages: 30 (24 generated)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sashab@chromium.org changed reviewers: + slangley@chromium.org
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2728873002/#ps40001 (title: "Fixed rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2728873002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489019039929220, "parent_rev": "35d7ec71638671b99f9490e84612bbfddd7b67b7", "commit_rev": "23681f7f9786a74472661de74377afcf19754ab1"}
Message was sent while issue was closed.
Description was changed from ========== Remove VisualViewport::frameHost() Remove the VisualViewport::frameHost() method, and replace it with Remove Remove VisualViewport::page() and update callsites. This is pre-work to remove FrameHost from VisualViewport, which is part of the work to remove FrameHost. BUG=691794 ========== to ========== Remove VisualViewport::frameHost() Remove the VisualViewport::frameHost() method, and replace it with Remove Remove VisualViewport::page() and update callsites. This is pre-work to remove FrameHost from VisualViewport, which is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2728873002 Cr-Commit-Position: refs/heads/master@{#455637} Committed: https://chromium.googlesource.com/chromium/src/+/23681f7f9786a74472661de74377... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/23681f7f9786a74472661de74377... |