Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2728873002: Remove VisualViewport::frameHost() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove VisualViewport::frameHost() Remove the VisualViewport::frameHost() method, and replace it with Remove Remove VisualViewport::page() and update callsites. This is pre-work to remove FrameHost from VisualViewport, which is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2728873002 Cr-Commit-Position: refs/heads/master@{#455637} Committed: https://chromium.googlesource.com/chromium/src/+/23681f7f9786a74472661de74377afcf19754ab1

Patch Set 1 #

Patch Set 2 : Fix compoile error #

Patch Set 3 : Fixed rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -34 lines) Patch
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 3 13 chunks +21 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 30 (24 generated)
sashab
3 years, 9 months ago (2017-03-02 03:16:34 UTC) #12
haraken
LGTM
3 years, 9 months ago (2017-03-02 03:20:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728873002/40001
3 years, 9 months ago (2017-03-08 03:42:08 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/335803)
3 years, 9 months ago (2017-03-08 04:06:42 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728873002/60001
3 years, 9 months ago (2017-03-09 00:24:29 UTC) #27
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 02:01:41 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/23681f7f9786a74472661de74377...

Powered by Google App Engine
This is Rietveld 408576698