Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2727563004: Change VisualViewport to store a Page instead of a FrameHost (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change VisualViewport to store a Page instead of a FrameHost This is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2727563004 Cr-Commit-Position: refs/heads/master@{#455987} Committed: https://chromium.googlesource.com/chromium/src/+/c0438224434b32dff5d3e15fb1b4b7a03d7e343a

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 2 3 4 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
sashab
3 years, 9 months ago (2017-03-02 06:20:40 UTC) #6
haraken
LGTM
3 years, 9 months ago (2017-03-02 07:27:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727563004/20001
3 years, 9 months ago (2017-03-09 02:31:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/379882) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-09 02:56:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727563004/20001
3 years, 9 months ago (2017-03-09 02:58:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/325370) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-09 02:58:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727563004/60001
3 years, 9 months ago (2017-03-10 02:08:09 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 04:12:41 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c0438224434b32dff5d3e15fb1b4...

Powered by Google App Engine
This is Rietveld 408576698