Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2728753002: Fix InterstitialPageImplTest to fail if frame is not focused correctly. (Closed)

Created:
3 years, 9 months ago by avallee
Modified:
3 years, 9 months ago
Reviewers:
alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix InterstitialPageImplTest to fail if frame is not focused correctly. See failing tests on https://codereview.chromium.org/2721303003 to show tests fail (hang) with this test fix, but without the impl fix. BUG=635656 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2728753002 Cr-Commit-Position: refs/heads/master@{#454097} Committed: https://chromium.googlesource.com/chromium/src/+/1a15baef08261f53209cd171e4ea200e221fc162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/frame_host/interstitial_page_impl_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
avallee
I'm running the tests in another cl with the impl fix commented out. They should ...
3 years, 9 months ago (2017-03-01 21:42:17 UTC) #4
alexmos
LGTM, thanks for following up on the test. I see that the InterstitialPageImplTest tests are ...
3 years, 9 months ago (2017-03-01 23:04:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728753002/1
3 years, 9 months ago (2017-03-01 23:36:57 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 23:44:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a15baef08261f53209cd171e4ea...

Powered by Google App Engine
This is Rietveld 408576698