Issue 2721303003: DO NOT SUBMIT: test the test impl. shoul fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2721303003: DO NOT SUBMIT: test the test impl. shoul fail (Closed)

Created:
3 years, 9 months ago by avallee

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DO NOT SUBMIT: test the test impl. shoul fail BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -8 lines)			Patch
M	content/browser/frame_host/interstitial_page_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/frame_host/interstitial_page_impl.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/frame_host/interstitial_page_impl_browsertest.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 2727483003 Patch 1

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

avallee

Description was changed from ========== DO NOT SUBMIT: test the test impl. shoul fail BUG= ...

3 years, 9 months ago (2017-03-01 21:38:50 UTC) #1

avallee

The CQ bit was checked by avallee@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-01 21:39:46 UTC) #2

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721303003/1

3 years, 9 months ago (2017-03-01 21:40:12 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-01 21:47:55 UTC) #4

commit-bot: I haz the power

3 years, 9 months ago (2017-03-01 21:47:56 UTC) #5

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages