[Courgette] Disassembler code movement and format fix.

[Courgette] Disassembler code movement and format fix.

We wish to rename ParseAbs32Relocs() and ParseRel32RelocsFromSections(),
and make them part of the Disassembler interface. This requires moving
chunks of code. This CL does the code movement as an independent change
to reduce noise later.

Also including reformatting changes from "git cl format".

BUG=660980
Review-Url: https://codereview.chromium.org/2728653003
Cr-Commit-Position: refs/heads/master@{#454068}
Committed: https://chromium.googlesource.com/chromium/src/+/dc779d9f0fab468f70ef7fb2cf5029e2373473dc

[huangs, 2017-03-01 19:22:32]

Description was changed from

==========
[Courgette] Disassembler code movement and format fix.

We wish to rename ParseAbs32Relocs() and ParseRel32RelocsFromSections(),
and make it part of the Disassembler interface. This requires moving
chunks of code. This CL does the code movement as a separate change to
remove noise later.

Also including 3 small reformatting changes from "git cl format".

BUG=660980
==========

to

==========
[Courgette] Disassembler code movement and format fix.

We wish to rename ParseAbs32Relocs() and ParseRel32RelocsFromSections(),
and make it part of the Disassembler interface. This requires moving
chunks of code. This CL does the code movement as a separate change to
remove noise later.

Also including reformatting changes from "git cl format".

BUG=660980
==========

[huangs, 2017-03-01 19:22:32]

huangs@chromium.org changed reviewers:
+ chrisha@chromium.org

[huangs, 2017-03-01 19:23:46]

Description was changed from

==========
[Courgette] Disassembler code movement and format fix.

We wish to rename ParseAbs32Relocs() and ParseRel32RelocsFromSections(),
and make it part of the Disassembler interface. This requires moving
chunks of code. This CL does the code movement as a separate change to
remove noise later.

Also including reformatting changes from "git cl format".

BUG=660980
==========

to

==========
[Courgette] Disassembler code movement and format fix.

We wish to rename ParseAbs32Relocs() and ParseRel32RelocsFromSections(),
and make them part of the Disassembler interface. This requires moving
chunks of code. This CL does the code movement as an independent change
to reduce noise later.

Also including reformatting changes from "git cl format".

BUG=660980
==========

[huangs, 2017-03-01 19:24:03]

Rather mechanical CL of code movement. PTAL.

[huangs, 2017-03-01 20:07:36]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:04:42]

Dry run: This issue passed the CQ dry run.

[Will Harris, 2017-03-01 22:01:54]

lgtm

[huangs, 2017-03-01 22:15:43]

Thanks for chiming in. Committing!

[huangs, 2017-03-01 22:16:34]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:17:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:22:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488406594833040, "parent_rev":
"63f8ee969fc93937374c9087b479634e533f1656", "commit_rev":
"dc779d9f0fab468f70ef7fb2cf5029e2373473dc"}

[commit-bot: I haz the power, 2017-03-01 22:23:20]

Description was changed from

==========
[Courgette] Disassembler code movement and format fix.

We wish to rename ParseAbs32Relocs() and ParseRel32RelocsFromSections(),
and make them part of the Disassembler interface. This requires moving
chunks of code. This CL does the code movement as an independent change
to reduce noise later.

Also including reformatting changes from "git cl format".

BUG=660980
==========

to

==========
[Courgette] Disassembler code movement and format fix.

We wish to rename ParseAbs32Relocs() and ParseRel32RelocsFromSections(),
and make them part of the Disassembler interface. This requires moving
chunks of code. This CL does the code movement as an independent change
to reduce noise later.

Also including reformatting changes from "git cl format".

BUG=660980

Review-Url: https://codereview.chromium.org/2728653003
Cr-Commit-Position: refs/heads/master@{#454068}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc779d9f0fab468f70ef7fb2cf50...
==========

[commit-bot: I haz the power, 2017-03-01 22:23:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc779d9f0fab468f70ef7fb2cf50...

[chrisha, 2017-03-02 20:01:06]

late to the party post-commit lgtm :)

[Will Harris, 2017-03-02 20:43:03]

eventually consistent lgtm is best lgtm