Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: courgette/disassembler_elf_32.h

Issue 2728653003: [Courgette] Disassembler code movement and format fix. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | courgette/disassembler_elf_32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler_elf_32.h
diff --git a/courgette/disassembler_elf_32.h b/courgette/disassembler_elf_32.h
index 3cf42e2e546107433cf7d4d9c411fe7bd7ed7b9f..fbd8a59ccc642b8d5c5e212bcf1bc070340ba089 100644
--- a/courgette/disassembler_elf_32.h
+++ b/courgette/disassembler_elf_32.h
@@ -179,6 +179,11 @@ class DisassemblerElf32 : public Disassembler {
virtual CheckBool ParseRel32RelocsFromSection(const Elf32_Shdr* section)
WARN_UNUSED_RESULT = 0;
+ CheckBool ParseAbs32Relocs() WARN_UNUSED_RESULT;
+
+ // Extracts all rel32 TypedRVAs. Does not sort the result.
+ CheckBool ParseRel32RelocsFromSections() WARN_UNUSED_RESULT;
+
// Disassembler interfaces.
RvaVisitor* CreateAbs32TargetRvaVisitor() override;
RvaVisitor* CreateRel32TargetRvaVisitor() override;
@@ -201,13 +206,8 @@ class DisassemblerElf32 : public Disassembler {
InstructionReceptor* receptor) const
WARN_UNUSED_RESULT;
- CheckBool ParseAbs32Relocs() WARN_UNUSED_RESULT;
-
CheckBool CheckSection(RVA rva) WARN_UNUSED_RESULT;
- // Extracts all rel32 TypedRVAs. Does not sort the result.
- CheckBool ParseRel32RelocsFromSections() WARN_UNUSED_RESULT;
-
const Elf32_Ehdr* header_;
Elf32_Half section_header_table_size_;
« no previous file with comments | « no previous file | courgette/disassembler_elf_32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698