Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2728543006: Fix core/frame PRESUBMIT for UseCounter changes (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix core/frame PRESUBMIT for UseCounter changes The start marker was missing a piece after https://codereview.chromium.org/2586863002 Review-Url: https://codereview.chromium.org/2728543006 Cr-Commit-Position: refs/heads/master@{#454312} Committed: https://chromium.googlesource.com/chromium/src/+/58d5486ea67d2b1065f616c1d604bd75a3026748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-02 16:42:00 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-02 17:27:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728543006/1
3 years, 9 months ago (2017-03-02 18:19:15 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 18:27:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58d5486ea67d2b1065f616c1d604...

Powered by Google App Engine
This is Rietveld 408576698