third_party/WebKit/Source/core/frame/PRESUBMIT.py - Issue 2728543006: Fix core/frame PRESUBMIT for UseCounter changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/PRESUBMIT.py

Issue 2728543006: Fix core/frame PRESUBMIT for UseCounter changes (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/PRESUBMIT.py

diff --git a/third_party/WebKit/Source/core/frame/PRESUBMIT.py b/third_party/WebKit/Source/core/frame/PRESUBMIT.py

index 40530edb9b17158134323c523a5a0a9c0a3e967a..589861be7649c971a0fcaa37eb7149f56e8d8e74 100644

--- a/third_party/WebKit/Source/core/frame/PRESUBMIT.py

+++ b/third_party/WebKit/Source/core/frame/PRESUBMIT.py

@@ -72,7 +72,7 @@ def _RunUmaHistogramChecks(input_api, output_api):

else:

return []

- START_MARKER = '^enum Feature {'

+ START_MARKER = '^enum Feature : uint32_t {'

END_MARKER = '^NumberOfFeatures'

if update_histogram_enum.HistogramNeedsUpdate(

histogram_enum_name='FeatureObserver',

« no previous file with comments | « no previous file | no next file » | no next file with comments »