Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2728503003: Update permission warning for contentSettings API

Created:
3 years, 9 months ago by meacer
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update permission warning for contentSettings API BUG=

Patch Set 1 #

Patch Set 2 : chrome.contentSettings API: Do not allow wildcard patterns that match extension URLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_settings/unsupporteddefaultsettings/test.js View 1 2 chunks +28 lines, -1 line 0 comments Download
M components/content_settings/core/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/content_settings/core/common/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/content_settings/core/common/content_settings_pattern.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/content_settings/core/common/content_settings_pattern.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 02:23:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728503003/1
3 years, 9 months ago (2017-03-01 02:24:04 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-01 03:40:29 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:40:29 UTC) #4
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698