Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11232)

Unified Diff: chrome/test/data/extensions/api_test/content_settings/unsupporteddefaultsettings/test.js

Issue 2728503003: Update permission warning for contentSettings API
Patch Set: chrome.contentSettings API: Do not allow wildcard patterns that match extension URLs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/content_settings/unsupporteddefaultsettings/test.js
diff --git a/chrome/test/data/extensions/api_test/content_settings/unsupporteddefaultsettings/test.js b/chrome/test/data/extensions/api_test/content_settings/unsupporteddefaultsettings/test.js
index d57487041ffcc461c9b2bdcb6f39504ca3c8f575..f5ed33fd5b317429e5ee8dda1975f56cdadd16c4 100644
--- a/chrome/test/data/extensions/api_test/content_settings/unsupporteddefaultsettings/test.js
+++ b/chrome/test/data/extensions/api_test/content_settings/unsupporteddefaultsettings/test.js
@@ -36,7 +36,7 @@ function expectFalse(message) {
}
chrome.test.runTests([
- function setDefaultContentSettings() {
+ function setDefaultContentSettingsAllUrls() {
settings.forEach(function(type, setting) {
cs[type].set({
'primaryPattern': '<all_urls>',
@@ -47,6 +47,33 @@ chrome.test.runTests([
"' is not supported as the default setting of " + type + "."));
});
},
+
+ // Patterns with scheme wildcards and extension IDs should not be added.
+ function setDefaultContentSettingsExtensionUrlWildcard() {
+ settings.forEach(function(type, setting) {
+ cs[type].set({
+ 'primaryPattern': '*://' + chrome.runtime.id + '/*',
+ 'secondaryPattern': '*://' + chrome.runtime.id + '/*',
+ 'setting': setting
+ },
+ chrome.test.callbackFail("'" + setting +
+ "' is not supported as the default setting of " + type + "."));
+ });
+ },
+
+ // Patterns with chrome-extension scheme and extension IDs should not be
+ // added.
+ function setDefaultContentSettingsExtensionUrlWildcard() {
+ settings.forEach(function(type, setting) {
+ cs[type].set({
+ 'primaryPattern': 'chrome-extension://' + chrome.runtime.id + '/*',
+ 'secondaryPattern': 'chrome-extension://' + chrome.runtime.id + '/*',
+ 'setting': setting
+ },
+ chrome.test.callbackFail("Invalid scheme."));
+ });
+ },
+
function setExceptions() {
settings.forEach(function(type, setting) {
cs[type].set({

Powered by Google App Engine
This is Rietveld 408576698