preload polymer elements in options page

preload polymer elements in options page

This CL is trying:
1. Pre-load polymer elements in options page for better
user experience.

2. Disable polymer pre-loading in browser_test to avoid racing.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2728453003
Cr-Commit-Position: refs/heads/master@{#455327}
Committed: https://chromium.googlesource.com/chromium/src/+/1cb6c0e588f5e30463c81be7a4a404911b5e3b6d

[xiaoyinh(OOO Sep 11-29), 2017-03-01 18:57:25]

Description was changed from

==========
Re-land "fix quick unlock config in options"
This CL is trying to fix 2 issues:
1. Quick unlock configuration in options are importing polymer
elements(lock_screen.html) created in settings, that includes importing
all the elements that lock_screen.html depends on. So if there's new
polymer elements imported in lock_screen.html, options wouldn't know
where to find them, thus not able to load the lock_screen element.
This CL makes options page know these newly added elements.

2. Trying to pre-load polymer elements in options page for better
user experience.

BUG=679795
==========

to

==========
Re-land "fix quick unlock config in options"
This CL is trying to fix 2 issues:
1. Quick unlock configuration in options are importing polymer
elements(lock_screen.html) created in settings, that includes importing
all the elements that lock_screen.html depends on. So if there's new
polymer elements imported in lock_screen.html, options wouldn't know
where to find them, thus not able to load the lock_screen element.
This CL makes options page know these newly added elements.

2. Trying to pre-load polymer elements in options page for better
user experience.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xiaoyinh(OOO Sep 11-29), 2017-03-02 19:39:16]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 19:39:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 20:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 20:57:12]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2017-03-02 23:42:16]

Description was changed from

==========
Re-land "fix quick unlock config in options"
This CL is trying to fix 2 issues:
1. Quick unlock configuration in options are importing polymer
elements(lock_screen.html) created in settings, that includes importing
all the elements that lock_screen.html depends on. So if there's new
polymer elements imported in lock_screen.html, options wouldn't know
where to find them, thus not able to load the lock_screen element.
This CL makes options page know these newly added elements.

2. Trying to pre-load polymer elements in options page for better
user experience.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Re-land "fix quick unlock config in options"

Original CL: https://codereview.chromium.org/2691943005/
This CL is trying to fix 2 issues:
1. Quick unlock configuration in options are importing polymer
elements(lock_screen.html) created in settings, that includes importing
all the elements that lock_screen.html depends on. So if there's new
polymer elements imported in lock_screen.html, options wouldn't know
where to find them, thus not able to load the lock_screen element.
This CL makes options page know these newly added elements.

2. Trying to pre-load polymer elements in options page for better
user experience.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xiaoyinh(OOO Sep 11-29), 2017-03-02 23:54:02]

xiaoyinh@chromium.org changed reviewers:
+ dbeam@chromium.org, jdufault@chromium.org, sky@chromium.org

[xiaoyinh(OOO Sep 11-29), 2017-03-02 23:54:02]

Original CL was breaking linux_chromium_chromeos_asan_rel_ng and
linux_chromium_chromeos_dbg_ng outside the CQ.(See patch 1).
The fix is in patch 2 which disables polymer preload in options page while it is
inside InProcessBrowserTest.
linux_chromium_chromeos_asan_rel_ng and linux_chromium_chromeos_dbg_ng have
passed in patch 2.

sky@, could you help to take a look changes in chrome/test?
jdufault@,dbeam@, could you help to take a look chrome/browser/resources/
chrome/browser/ui/webui/options

Thanks!

[sky, 2017-03-02 23:59:57]

Can you describe why you are disabling the test on chromeos?

[xiaoyinh(OOO Sep 11-29), 2017-03-03 00:34:04]

On 2017/03/02 23:59:57, sky wrote:
> Can you describe why you are disabling the test on chromeos?

So the CL is trying to preload polymer elements in chrome://settings-frame when
the browser is idle vs requestIdleCallback.
The content of these polymer elements are not shown until user opens the quick
unlock overlay. 

This seems to race with this browsertest
PolicyPrefIndicatorTest:CheckPolicyIndicators. In the browser test, it 
navigates to chrome://settings-frame and once the page is loaded, it executes
some js code which is probably at the same time as we start to preload polymer.
I'm trying to not preload polymer in the browsertest to avoid racing, since in
the browsertest we don't need these polymer elements.

Please let me know if you think otherwise. Thanks!

[Dan Beam, 2017-03-03 03:09:20]

can you split the "fix this UI" and the "preload this UI" into separate CLs
maybe?

[sky, 2017-03-03 04:21:34]

On 2017/03/03 00:34:04, xiaoyinh wrote:
> On 2017/03/02 23:59:57, sky wrote:
> > Can you describe why you are disabling the test on chromeos?
> 
> So the CL is trying to preload polymer elements in chrome://settings-frame
when
> the browser is idle vs requestIdleCallback.
> The content of these polymer elements are not shown until user opens the quick
> unlock overlay. 
> 
> This seems to race with this browsertest
> PolicyPrefIndicatorTest:CheckPolicyIndicators. In the browser test, it 
> navigates to chrome://settings-frame and once the page is loaded, it executes
> some js code which is probably at the same time as we start to preload
polymer.
> I'm trying to not preload polymer in the browsertest to avoid racing, since in
> the browsertest we don't need these polymer elements.
> 
> Please let me know if you think otherwise. Thanks!

This makes sense, but what is specific to chromeos in this? Also, please add a
comment to the ifdfef.

[xiaoyinh(OOO Sep 11-29), 2017-03-03 19:47:04]

Description was changed from

==========
Re-land "fix quick unlock config in options"

Original CL: https://codereview.chromium.org/2691943005/
This CL is trying to fix 2 issues:
1. Quick unlock configuration in options are importing polymer
elements(lock_screen.html) created in settings, that includes importing
all the elements that lock_screen.html depends on. So if there's new
polymer elements imported in lock_screen.html, options wouldn't know
where to find them, thus not able to load the lock_screen element.
This CL makes options page know these newly added elements.

2. Trying to pre-load polymer elements in options page for better
user experience.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
preload polymer elements in options page

This CL is trying:
1. Pre-load polymer elements in options page for better
user experience.

2. Disable polymer pre-loading in browser_test to avoid racing.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xiaoyinh(OOO Sep 11-29), 2017-03-03 19:50:40]

On 2017/03/03 03:09:20, Dan Beam wrote:
> can you split the "fix this UI" and the "preload this UI" into separate CLs
> maybe?

Thanks for the suggestion. I have split the former into another CL:
https://codereview.chromium.org/2728173002/#ps20001
Will keep this CL for the pre-loading part only.

[Dan Beam, 2017-03-03 19:59:37]

On 2017/03/03 04:21:34, sky wrote:
> On 2017/03/03 00:34:04, xiaoyinh wrote:
> > On 2017/03/02 23:59:57, sky wrote:
> > > Can you describe why you are disabling the test on chromeos?
> > 
> > So the CL is trying to preload polymer elements in chrome://settings-frame
> when
> > the browser is idle vs requestIdleCallback.
> > The content of these polymer elements are not shown until user opens the
quick
> > unlock overlay. 
> > 
> > This seems to race with this browsertest
> > PolicyPrefIndicatorTest:CheckPolicyIndicators. In the browser test, it 
> > navigates to chrome://settings-frame and once the page is loaded, it
executes
> > some js code which is probably at the same time as we start to preload
> polymer.
> > I'm trying to not preload polymer in the browsertest to avoid racing, since
in
> > the browsertest we don't need these polymer elements.
> > 
> > Please let me know if you think otherwise. Thanks!
> 
> This makes sense, but what is specific to chromeos in this? Also, please add a
> comment to the ifdfef.

sky@: the feature of "pin unlock" only exists on ChromeOS.  ChromeOS team made
the call to import parts of the NEW settings page into the OLD options page and
share some code between them.  so, only on ChromeOS are they pulling in the
Polymer-based version.

[xiaoyinh(OOO Sep 11-29), 2017-03-03 20:14:57]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 20:15:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 21:13:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 21:13:03]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-06 16:27:37]

LGTM

[Dan Beam, 2017-03-07 18:10:17]

lgtm

[xiaoyinh(OOO Sep 11-29), 2017-03-07 19:03:44]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 19:05:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 20:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:12:25]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2017-03-08 01:24:13]

The CQ bit was checked by xiaoyinh@chromium.org

[xiaoyinh(OOO Sep 11-29), 2017-03-08 01:24:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2728453003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-08 01:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:36:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488936253203700,
"parent_rev": "6f16f9098ad2c1da54ac2ca6ea3b203c177b6119", "commit_rev":
"1cb6c0e588f5e30463c81be7a4a404911b5e3b6d"}

[commit-bot: I haz the power, 2017-03-08 01:37:08]

Description was changed from

==========
preload polymer elements in options page

This CL is trying:
1. Pre-load polymer elements in options page for better
user experience.

2. Disable polymer pre-loading in browser_test to avoid racing.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
preload polymer elements in options page

This CL is trying:
1. Pre-load polymer elements in options page for better
user experience.

2. Disable polymer pre-loading in browser_test to avoid racing.

BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2728453003
Cr-Commit-Position: refs/heads/master@{#455327}
Committed:
https://chromium.googlesource.com/chromium/src/+/1cb6c0e588f5e30463c81be7a4a4...
==========

[commit-bot: I haz the power, 2017-03-08 01:37:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1cb6c0e588f5e30463c81be7a4a4...