Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2728173002: Fix quick unlock config in options (Closed)

Created:
3 years, 9 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 9 months ago
Reviewers:
jdufault, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix quick unlock config in options This CL is trying to fix the following issue: Quick unlock configuration in options are importing polymer elements(lock_screen.html) created in settings, that includes importing all the elements that lock_screen.html depends on. So if there's new polymer elements imported in lock_screen.html, options wouldn't know where to find them, thus not able to load the lock_screen element. This CL makes options page know these newly added elements. BUG=679795 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2728173002 Cr-Commit-Position: refs/heads/master@{#454675} Committed: https://chromium.googlesource.com/chromium/src/+/1a9f983b18d21da00d0e64647a0adbd91d7fbbb5

Patch Set 1 : original CL(with preload) #

Patch Set 2 : Remove polymer preload in options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -67 lines) Patch
A chrome/browser/resources/options/i18n_setup.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options_resources.grd View 2 chunks +32 lines, -58 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_screen.js View 4 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 3 chunks +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
xiaoyinh(OOO Sep 11-29)
Hi, could you help to take a look? I removed the preload part and everything ...
3 years, 9 months ago (2017-03-03 19:44:10 UTC) #6
Dan Beam
lgtm
3 years, 9 months ago (2017-03-03 19:57:48 UTC) #7
jdufault
lgtm
3 years, 9 months ago (2017-03-03 19:57:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728173002/20001
3 years, 9 months ago (2017-03-03 21:08:23 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 21:15:07 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a9f983b18d21da00d0e64647a0a...

Powered by Google App Engine
This is Rietveld 408576698