Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2728183003: Revert of Server push cancellation: add a finch trial parameter (Closed)

Created:
3 years, 9 months ago by sclittle
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Server push cancellation: add a finch trial parameter (patchset #15 id:300001 of https://codereview.chromium.org/2692813002/ ) Reason for revert: Broke net_unittests on Win7 (dbg) bot: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/57830 Original issue's description: > Server push cancellation: add a finch trial parameter > "enable_server_push_cancellation" to control the feature of server push > cancellation. Create a HttpCacheLookupManager in HttpCache's constructor > and set it to HttpNetworkSession which will set it thru reaching > QuicChromiumClientSession and SpdySession. > > BUG=232040 > > Review-Url: https://codereview.chromium.org/2692813002 > Cr-Original-Commit-Position: refs/heads/master@{#454457} > Committed: https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7a8cd805f13e8 > Review-Url: https://codereview.chromium.org/2692813002 > Cr-Commit-Position: refs/heads/master@{#454679} > Committed: https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051df4be0b13964f TBR=rch@chromium.org,ckrasic@chromium.org,zhongyi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=232040 Review-Url: https://codereview.chromium.org/2728183003 Cr-Commit-Position: refs/heads/master@{#454706} Committed: https://chromium.googlesource.com/chromium/src/+/46a595cd9b30990f40400a81e9b99483f533cafa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -331 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +8 lines, -15 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_session_visitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 6 chunks +0 lines, -230 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sclittle
Created Revert of Server push cancellation: add a finch trial parameter
3 years, 9 months ago (2017-03-03 23:22:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728183003/1
3 years, 9 months ago (2017-03-03 23:23:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/46a595cd9b30990f40400a81e9b99483f533cafa
3 years, 9 months ago (2017-03-03 23:24:50 UTC) #6
Ryan Hamilton
On 2017/03/03 23:24:50, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-04 04:17:53 UTC) #7
sclittle
3 years, 9 months ago (2017-03-06 18:28:20 UTC) #8
Message was sent while issue was closed.
On 2017/03/04 04:17:53, Ryan Hamilton wrote:
> On 2017/03/03 23:24:50, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/46a595cd9b30990f40400a81e9b9...
> 
> How can we target a win7 bot in order to verify this?

Looking at the answer from
https://groups.google.com/a/chromium.org/forum/#!topic/infra-dev/bIeyq_F0pHU,
and
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...:

It looks like the "win_chromium_dbg_ng" trybot corresponds to the "Win7 Tests
(dbg)(1)" builder that failed.

Powered by Google App Engine
This is Rietveld 408576698