Make TextControlElement::indexForVisiblePosition() not to use temporary Range

Make TextControlElement::indexForVisiblePosition() not to use temporary Range

This patch makes |TextControlElement::indexForVisiblePosition()| to call
|TextIterator::rangeLength()| without using temporary |Range| object to avoid
registering temporary |Range| object into register update list to reduce memory
usage an relocation cost for improving code halth.

BUG=691200
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2727923002
Cr-Commit-Position: refs/heads/master@{#454461}
Committed: https://chromium.googlesource.com/chromium/src/+/99ed48423a76851451298d54a5260cc30503fa1d

[yosin_UTC9, 2017-03-02 07:18:03]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[yosin_UTC9, 2017-03-02 07:18:17]

Description was changed from

==========
2017-03-02T16:16:45

2017-03-02T16:16:32

BUG=
==========

to

==========
2017-03-02T16:16:45

2017-03-02T16:16:32

BUG=691200
==========

[commit-bot: I haz the power, 2017-03-02 07:18:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-02 07:56:14]

Description was changed from

==========
2017-03-02T16:16:45

2017-03-02T16:16:32

BUG=691200
==========

to

==========
Make TextControlElement::indexForVisiblePosition() not to use temporary Range

This patch makes |TextControlElement::indexForVisiblePosition()| to use
|EphemeralRange| instead of temporary |Range| object to avoid registering
temporary |Range| to range update list to reduce memory usage and relocation
cost.

BUG=691200
TEST=n/a; no behavior change
==========

[yosin_UTC9, 2017-03-02 09:05:51]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-02 09:05:52]

PTAL

[commit-bot: I haz the power, 2017-03-02 09:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 09:13:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yoichio, 2017-03-02 09:15:21]

lgtm

[tkent, 2017-03-02 23:00:42]

> This patch makes |TextControlElement::indexForVisiblePosition()| to use
> |EphemeralRange| instead of temporary |Range| object to avoid registering

The new code doesn't look to use EphemeralRange.

[tkent, 2017-03-02 23:41:05]

> The new code doesn't look to use EphemeralRange.

lgtm anyway

[yosin_UTC9, 2017-03-03 01:09:57]

Description was changed from

==========
Make TextControlElement::indexForVisiblePosition() not to use temporary Range

This patch makes |TextControlElement::indexForVisiblePosition()| to use
|EphemeralRange| instead of temporary |Range| object to avoid registering
temporary |Range| to range update list to reduce memory usage and relocation
cost.

BUG=691200
TEST=n/a; no behavior change
==========

to

==========
Make TextControlElement::indexForVisiblePosition() not to use temporary Range

This patch makes |TextControlElement::indexForVisiblePosition()| to call
|TextIterator::rangeLength()| without using temporary |Range| object to avoid
registering temporary |Range| object into register update list to reduce memory
usage an relocation cost for improving code halth.

BUG=691200
TEST=n/a; no behavior change
==========

[yosin_UTC9, 2017-03-03 01:10:11]

On 2017/03/02 at 23:41:05, tkent wrote:
> > The new code doesn't look to use EphemeralRange.
> 
> lgtm anyway

Oops. Update a description.

[yosin_UTC9, 2017-03-03 01:10:16]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-03 01:10:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 01:51:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488503416158570, "parent_rev":
"9d8c99cfe73e17fccae5512ef7abf38381370a17", "commit_rev":
"99ed48423a76851451298d54a5260cc30503fa1d"}

[commit-bot: I haz the power, 2017-03-03 01:52:58]

Description was changed from

==========
Make TextControlElement::indexForVisiblePosition() not to use temporary Range

This patch makes |TextControlElement::indexForVisiblePosition()| to call
|TextIterator::rangeLength()| without using temporary |Range| object to avoid
registering temporary |Range| object into register update list to reduce memory
usage an relocation cost for improving code halth.

BUG=691200
TEST=n/a; no behavior change
==========

to

==========
Make TextControlElement::indexForVisiblePosition() not to use temporary Range

This patch makes |TextControlElement::indexForVisiblePosition()| to call
|TextIterator::rangeLength()| without using temporary |Range| object to avoid
registering temporary |Range| object into register update list to reduce memory
usage an relocation cost for improving code halth.

BUG=691200
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2727923002
Cr-Commit-Position: refs/heads/master@{#454461}
Committed:
https://chromium.googlesource.com/chromium/src/+/99ed48423a76851451298d54a526...
==========

[commit-bot: I haz the power, 2017-03-03 01:52:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99ed48423a76851451298d54a526...